Implement spec for Profile Pushdown

Bug #1044738 reported by Paul Everitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Low
Carlos de la Guardia
Changed in karl3:
milestone: m116 → m117
Changed in karl3:
importance: Medium → Low
JimPGlenn (jpglenn09)
Changed in karl3:
milestone: m117 → m118
Revision history for this message
Carlos de la Guardia (cguardia) wrote :

This is nearly done, but I think it requires a test drive and probably a round of small fixes before marking fix committed.

Deployed at cguardia-1044738-profile-pushdown

Changed in karl3:
status: New → In Progress
Revision history for this message
Paul Everitt (paul-agendaless) wrote : Re: [Bug 1044738] Implement spec for Profile Pushdown

That looks really good!

Thinking back on it, perhaps we should switch the left and right column. If I just clicked on "My Profile", and my goal was to actually go my profile, it would be nice to have the link a lot closer to where I just clicked. Agree?

Should we do a bigger picture for the person?

--Paul

On Sep 11, 2012, at 2:50 AM, Carlos de la Guardia <email address hidden> wrote:

> This is nearly done, but I think it requires a test drive and probably a
> round of small fixes before marking fix committed.
>
> Deployed at cguardia-1044738-profile-pushdown
>
> ** Changed in: karl3
> Status: New => In Progress
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1044738
>
> Title:
> Implement spec for Profile Pushdown
>
> Status in KARL3:
> In Progress
>
> Bug description:
> Spec at http://index.karlproject.org/docs/specs/drafts/profile-
> pushdown.html
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1044738/+subscriptions

Revision history for this message
Carlos de la Guardia (cguardia) wrote :

Made the column and pic changes. I think it does look better.

Changed in karl3:
status: In Progress → Fix Committed
Revision history for this message
JimPGlenn (jpglenn09) wrote :

Looks good but I lost my logout option after going to the page.

Changed in karl3:
status: Fix Committed → In Progress
Revision history for this message
Carlos de la Guardia (cguardia) wrote :

That's actually part of the spec (it's now on the pushdown itself). However, the spec will be changing soon, so let's keep this one in progress.

Revision history for this message
JimPGlenn (jpglenn09) wrote :

Yes I missed that.. looks good. let me know if you need more testing

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Some changes from Nat, first about the communities column:

- Change the heading to be "My Active Communities"

- For your "preferred" communities, find the five most recently "active"

- List these in reverse chronological order based on activity date

- On each entry, put on a second line (in a smaller font) a list of links to each tool, separated by vertical bars

###

Other:

- For the icon, don't scale up the little one. Scale down the bigger profile icon.

- "Open profile" -> "Full Profile"

- Make "Full Profile" and "Logout" into chrome links, which should get the underline. If we like that, we'll apply it to all non-content links in the pushdowns

Changed in karl3:
status: In Progress → Fix Committed
JimPGlenn (jpglenn09)
tags: added: cguardia-1044738-profile-pushdown
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Carlos, I think we have a few small issues left on the styling:

1) Still need the timeago move to the left margin

2) The vertical bar on the listing of tools can probably lose the first and last one. Instead of:

| Overview | Calendar |

...you can do:

Overview | Calendar

--Paul

On Sep 12, 2012, at 11:38 PM, Carlos de la Guardia <email address hidden> wrote:

> ** Changed in: karl3
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1044738
>
> Title:
> Implement spec for Profile Pushdown
>
> Status in KARL3:
> Fix Committed
>
> Bug description:
> Spec at http://index.karlproject.org/docs/specs/drafts/profile-
> pushdown.html
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1044738/+subscriptions

Changed in karl3:
status: Fix Committed → In Progress
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Oops, forgot the screencast I did:

http://www.screencast.com/t/rIxUKPX1TbM

--Paul

On Sep 13, 2012, at 10:19 AM, Paul Everitt <email address hidden> wrote:

>
> Carlos, I think we have a few small issues left on the styling:
>
> 1) Still need the timeago move to the left margin
>
> 2) The vertical bar on the listing of tools can probably lose the first and last one. Instead of:
>
> | Overview | Calendar |
>
> ...you can do:
>
> Overview | Calendar
>
> --Paul
>
> On Sep 12, 2012, at 11:38 PM, Carlos de la Guardia <email address hidden> wrote:
>
>> ** Changed in: karl3
>> Status: In Progress => Fix Committed
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1044738
>>
>> Title:
>> Implement spec for Profile Pushdown
>>
>> Status in KARL3:
>> Fix Committed
>>
>> Bug description:
>> Spec at http://index.karlproject.org/docs/specs/drafts/profile-
>> pushdown.html
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/karl3/+bug/1044738/+subscriptions
>

Revision history for this message
Carlos de la Guardia (cguardia) wrote :

Fixed those details. Long titles on recent content seem to work fine at least on Chrome and Firefox on Linux. The timeago gets pushed to the left (it's left-aligned now, though).

Revision history for this message
Paul Everitt (paul-agendaless) wrote : Re: [Bug 1044738] Re: Implement spec for Profile Pushdown

Is this ready for Fix Committed?

--Paul

On Sep 13, 2012, at 11:16 AM, Carlos de la Guardia <email address hidden> wrote:

> Fixed those details. Long titles on recent content seem to work fine at
> least on Chrome and Firefox on Linux. The timeago gets pushed to the
> left (it's left-aligned now, though).
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1044738
>
> Title:
> Implement spec for Profile Pushdown
>
> Status in KARL3:
> In Progress
>
> Bug description:
> Spec at http://index.karlproject.org/docs/specs/drafts/profile-
> pushdown.html
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1044738/+subscriptions

Revision history for this message
Carlos de la Guardia (cguardia) wrote :

It is, I think.

Changed in karl3:
status: In Progress → Fix Committed
JimPGlenn (jpglenn09)
tags: added: r3.97 tested
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Chris said this is missing a test for the new view

Changed in karl3:
status: Fix Committed → In Progress
JimPGlenn (jpglenn09)
tags: removed: r3.97 tested
Revision history for this message
Carlos de la Guardia (cguardia) wrote :

Added test.

Changed in karl3:
status: In Progress → Fix Committed
Revision history for this message
JimPGlenn (jpglenn09) wrote :

looks ready for release

tags: added: r3.97 tested
Revision history for this message
JimPGlenn (jpglenn09) wrote :

implemented

Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.