Windows docker driver config file

Bug #1787565 reported by Michał Kostrzewa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Undecided
Unassigned
OpenContrail
Fix Committed
Undecided
Unassigned

Bug Description

Docker Driver lacks configuration file.

Tags: windows
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/45634
Submitter: Michal Kostrzewa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45634
Committed: http://github.com/Juniper/contrail-windows-docker-driver/commit/33bf8bdb1bbe83384872befea8bcf170fb70e198
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 33bf8bdb1bbe83384872befea8bcf170fb70e198
Author: Michal Kostrzewa <email address hidden>
Date: Thu May 10 12:18:00 2018 +0200

Add configuration file.

This is based on Jacek Izykowski's work:
https://github.com/Juniper/contrail-windows-docker-driver/pull/21

Initial patchset is a merge of his work to master. Following patchsets are fixes and
improvements.

Changes:
* Remove loading keystone variables from environment.
* Introduce an ini-format config file.
* Command line params take precedence over config params.
* Move flags to configuration/ package.
* Refactors.
* Introduce dryRun flag that parses config but doesn't do anything.
* Bake sample test config file into test binary using go generate. This
is done so that we don't have to complicate integration test setup on
CI-side and needlessly couple it. It will be easier to add test cases
this way as well.

Co-authored-by: Jacek Izykowski <email address hidden>
Co-authored-by: Michal Kostrzewa <email address hidden>

Change-Id: I92f0df4f84f519836a0af183cc4580f72189feb0
Closes-Bug: #1787565

Changed in opencontrail:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.