Coverity issues in vrouter dpdk

Bug #1758056 reported by Andrei Bunghez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
In Progress
High
Andrei Bunghez
Trunk
In Progress
High
Andrei Bunghez
OpenContrail
New
Undecided
Andrei Bunghez

Bug Description

opencontrail master

Hi,

Coverity reports several issues in vrouter/dpdk. I would like to use this issue to track them as I address them. To begin with:

vr_dpdk_netlink.c: 289 - descriptor will be leaked in (the unlikely) case it is 0. (63834)

vr_dpdk_table_mem.c: 115 - sys_fp is leaked if a new iteration takes the same path. (63770)

vr_dpdk_interface.c: 562 - strncpy with buffer size as argument might lead to non-"null terminated" string (63951).

vr_uvhost.c: In vr_uvhost_start, s is a socket descriptor which can be >= 0 if socket returns success. The "if (s)" on error case (where this comparison is true as s might be -1) leads to unlinking an uninitialized sun.sun_path. (64029, 63838)

vr_dpdk_virtio.c: vring_idx check in vr_dpdk_set_ring_num_desc (63924)

Tags: vrouter
Changed in opencontrail:
assignee: nobody → Andrei Bunghez (abunghez)
Revision history for this message
Andrei Bunghez (abunghez) wrote :

Also:
vr_dpdk_virtio.c: vring_idx check in vr_dpdk_set_ring_num_desc (63924)

description: updated
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40953
Submitter: Andrei Bunghez (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42687
Submitter: Andrei Bunghez (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40953
Submitter: Andrei Bunghez (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42755
Submitter: Andrei Bunghez (<email address hidden>)

Revision history for this message
Sivakumar Ganapathy (hotlava51) wrote :

Not critical for 5.0.2 as it is just coverity warnings.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47311
Submitter: Kiran (<email address hidden>)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.