vrouter outputs wrong dst lcores

Bug #1784761 reported by Yi-y-yang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Fix Committed
High
Yi-y-yang
Trunk
Fix Committed
High
Yi-y-yang
OpenContrail
New
Undecided
Unassigned

Bug Description

We noticed vrouter always outputs wrong dst lcores.

2018-07-30 20:36:06,252 VROUTER: Lcore 12: distributing MPLSoGRE packets to [10,11,12,14,15,16,17]
2018-07-30 20:36:06,252 VROUTER: Lcore 16: distributing MPLSoGRE packets to [10,11,12,13,14,15,17]
2018-07-30 20:36:06,252 VROUTER: Lcore 13: distributing MPLSoGRE packets to [10,11,12,13,14,15,16]
2018-07-30 20:36:06,252 VROUTER: Lcore 11: distributing MPLSoGRE packets to [10,11,12,13,14,15,16]
2018-07-30 20:36:06,252 VROUTER: Lcore 15: distributing MPLSoGRE packets to [10,11,12,13,14,15,16]
2018-07-30 20:36:06,253 VROUTER: Lcore 17: distributing MPLSoGRE packets to [10,11,12,13,14,15,16]
2018-07-30 20:36:06,253 VROUTER: Lcore 14: distributing MPLSoGRE packets to [10,11,12,13,14,15,16]
2018-07-30 20:36:06,253 VROUTER: Lcore 10: distributing MPLSoGRE packets to [10,11,12,13,14,15,16]

The root cause is multiple threads are using the same static string buffer to get dst lcores by dpdk_lcore_dst_lcores_stringify, that will result in wrong output.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/45152
Submitter: Yi Yang (<email address hidden>)

Jeba Paulaiyan (jebap)
tags: added: vrouter
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45152
Committed: http://github.com/Juniper/contrail-vrouter/commit/9c1137caa633754c1bcf21b88fbe2dba0d8928bb
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 9c1137caa633754c1bcf21b88fbe2dba0d8928bb
Author: Yi Yang <email address hidden>
Date: Tue Jul 31 18:40:10 2018 -0700

Fix wrong dst lcroes output in contrail-vrouter-dpdk log

Wrong log: VROUTER: Lcore 12: distributing MPLSoGRE packets to [10,11,12,14,15,16,17]

Right log: VROUTER: Lcore 12: distributing MPLSoGRE packets to [10,11,13,14,15,16,17]

Change-Id: I8c2781315d1fed54627774b3711ca94342b38f31
Closes-Bug: #1784761
Signed-off-by: Yi Yang <email address hidden>

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/45183
Submitter: Jeya ganesh babu (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45183
Committed: http://github.com/Juniper/contrail-vrouter/commit/4256114385669c26799957167ca0acda3a7319ba
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 4256114385669c26799957167ca0acda3a7319ba
Author: Yi Yang <email address hidden>
Date: Tue Jul 31 18:40:10 2018 -0700

Fix wrong dst lcroes output in contrail-vrouter-dpdk log

Wrong log: VROUTER: Lcore 12: distributing MPLSoGRE packets to [10,11,12,14,15,16,17]

Right log: VROUTER: Lcore 12: distributing MPLSoGRE packets to [10,11,13,14,15,16,17]

Change-Id: I8c2781315d1fed54627774b3711ca94342b38f31
Closes-Bug: #1784761
Signed-off-by: Yi Yang <email address hidden>
(cherry picked from commit 9c1137caa633754c1bcf21b88fbe2dba0d8928bb)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.