control-node sends malformed update when 26 or more networks are attached to SNAT instance

Bug #1454431 reported by Pedro Marques
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R1.1
Fix Committed
High
Prakash Bailkeri
R2.0
Fix Committed
High
Prakash Bailkeri
R2.1
Fix Committed
High
Prakash Bailkeri
R2.20
Fix Committed
High
Prakash Bailkeri
Trunk
Fix Committed
High
Prakash Bailkeri
OpenContrail
Fix Released
High
Pedro Marques

Bug Description

Control-node doesn't know how to encode more than 31 Extended Communities in a BGP UPDATE message.
When a source-nat instance is attached to 20+ internal networks, the resulting numbers of extended communities ends up being more than 31 and the UPDATE is malformed.

The control-node also crashes when sending a Notification for an update that is more than 256 bytes.

Pedro Marques (5-roque)
Changed in opencontrail:
assignee: nobody → Pedro Marques (5-roque)
status: New → Confirmed
Nischal Sheth (nsheth)
tags: added: contrail-control
Nischal Sheth (nsheth)
Changed in opencontrail:
importance: Undecided → High
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : master

Review in progress for https://review.opencontrail.org/10270
Submitter: Pedro Marques (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.20

Review in progress for https://review.opencontrail.org/10418
Submitter: Pedro Marques (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.1

Review in progress for https://review.opencontrail.org/10421
Submitter: Pedro Marques (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.0

Review in progress for https://review.opencontrail.org/10422
Submitter: Pedro Marques (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R1.10

Review in progress for https://review.opencontrail.org/10437
Submitter: Pedro Marques (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/10270
Committed: http://github.org/Juniper/contrail-controller/commit/ac270a963d8b8386f6ca6af2d035eede679feea3
Submitter: Zuul
Branch: master

commit ac270a963d8b8386f6ca6af2d035eede679feea3
Author: Pedro Marques <email address hidden>
Date: Wed May 13 01:19:22 2015 +0000

Add BGP ExtendedLength attribute encoding.

Add support for Extended Length encoding for variable length BGP
attributes. Revamp the exploratory tests so that larger messages get
generated. Fix the encoding of Unknown Attributes. When generating
NOTIFICATIONs use a max message size buffer and do not assert if
encoding fails.

Closes-bug: #1454431

Change-Id: I545e28f61b4d7a840b73fb890da88a6322b2ecbf

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/10418
Committed: http://github.org/Juniper/contrail-controller/commit/34a6051147939d6f758f8755cec4ef5dad26e14f
Submitter: Zuul
Branch: R2.20

commit 34a6051147939d6f758f8755cec4ef5dad26e14f
Author: Pedro Marques <email address hidden>
Date: Wed May 13 01:19:22 2015 +0000

Add BGP ExtendedLength attribute encoding.

Add support for Extended Length encoding for variable length BGP
attributes. Revamp the exploratory tests so that larger messages get
generated. Fix the encoding of Unknown Attributes. When generating
NOTIFICATIONs use a max message size buffer and do not assert if
encoding fails.

Closes-bug: #1454431

Change-Id: I545e28f61b4d7a840b73fb890da88a6322b2ecbf

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.1

Review in progress for https://review.opencontrail.org/10421
Submitter: Pedro Marques (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.0

Review in progress for https://review.opencontrail.org/10422
Submitter: Pedro Marques (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/10421
Committed: http://github.org/Juniper/contrail-controller/commit/ffe1a389e9570875433d1c4b87f8f0f1b45904af
Submitter: Zuul
Branch: R2.1

commit ffe1a389e9570875433d1c4b87f8f0f1b45904af
Author: Pedro Marques <email address hidden>
Date: Wed May 13 01:19:22 2015 +0000

Add BGP ExtendedLength attribute encoding.

Add support for Extended Length encoding for variable length BGP
attributes. Revamp the exploratory tests so that larger messages get
generated. Fix the encoding of Unknown Attributes. When generating
NOTIFICATIONs use a max message size buffer and do not assert if
encoding fails.

Closes-bug: #1454431

Change-Id: I545e28f61b4d7a840b73fb890da88a6322b2ecbf

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/10422
Committed: http://github.org/Juniper/contrail-controller/commit/3d6486b86ad54bdbaa6b3e4518d5d02a8f58a18e
Submitter: Zuul
Branch: R2.0

commit 3d6486b86ad54bdbaa6b3e4518d5d02a8f58a18e
Author: Pedro Marques <email address hidden>
Date: Wed May 13 01:19:22 2015 +0000

Add BGP ExtendedLength attribute encoding.

Add support for Extended Length encoding for variable length BGP
attributes. Revamp the exploratory tests so that larger messages get
generated. Fix the encoding of Unknown Attributes. When generating
NOTIFICATIONs use a max message size buffer and do not assert if
encoding fails.

Closes-bug: #1454431

Change-Id: I545e28f61b4d7a840b73fb890da88a6322b2ecbf

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/10437
Committed: http://github.org/Juniper/contrail-controller/commit/b4bc442a66139f80d065c123a84b370367beb0ac
Submitter: Zuul
Branch: R1.10

commit b4bc442a66139f80d065c123a84b370367beb0ac
Author: Pedro Marques <email address hidden>
Date: Wed May 13 01:19:22 2015 +0000

Add BGP ExtendedLength attribute encoding.

Add support for Extended Length encoding for variable length BGP
attributes. Revamp the exploratory tests so that larger messages get
generated. Fix the encoding of Unknown Attributes. When generating
NOTIFICATIONs use a max message size buffer and do not assert if
encoding fails.

Closes-bug: #1454431

Change-Id: I545e28f61b4d7a840b73fb890da88a6322b2ecbf

Pedro Marques (5-roque)
Changed in opencontrail:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.