config: fix inefficient sorting in list operations

Bug #1416089 reported by Hampapur Ajay
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Fix Committed
Critical
Hampapur Ajay
R1.1
Fix Committed
Critical
Hampapur Ajay
R2.0
Fix Committed
Critical
Hampapur Ajay
R2.1
Fix Committed
Critical
Hampapur Ajay
OpenContrail
Fix Committed
Critical
Hampapur Ajay

Bug Description

In the autogenerated code (by generateDS) in scale tests encountered an inefficient sort operation within a loop during list api implementation. Need to fix this to be outside the loop.

Tags: blocker config
Hampapur Ajay (hajay)
Changed in opencontrail:
assignee: nobody → Hampapur Ajay (hajay)
importance: Undecided → Critical
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/6786
Committed: http://github.org/Juniper/contrail-generateDS/commit/74b8b44e456f529a06c26a5a91b33444752a2bd6
Submitter: Zuul
Branch: R2.1

commit 74b8b44e456f529a06c26a5a91b33444752a2bd6
Author: Hampapur Ajay <email address hidden>
Date: Thu Jan 29 12:20:52 2015 -0800

config-autogen: generate sort operation outside for loop

List operations in scale tests are inefficient due to incorrect
position of sort call.

Change-Id: Id695a55a48945806cd477a1520731f45fb691c56
Closes-Bug: #1416089

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/6791
Committed: http://github.org/Juniper/contrail-generateDS/commit/28137d4a15cc921b3300bfb150617bff5cc7c0be
Submitter: Zuul
Branch: master

commit 28137d4a15cc921b3300bfb150617bff5cc7c0be
Author: Hampapur Ajay <email address hidden>
Date: Thu Jan 29 12:20:52 2015 -0800

config-autogen: generate sort operation outside for loop

List operations in scale tests are inefficient due to incorrect
position of sort call.

Change-Id: Id695a55a48945806cd477a1520731f45fb691c56
Closes-Bug: #1416089

Changed in juniperopenstack:
status: New → Fix Committed
Changed in opencontrail:
status: New → Fix Committed
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/6793
Committed: http://github.org/Juniper/contrail-generateDS/commit/081ebc3878d5aa9c1987fb490e51e7b5b33e9f91
Submitter: Zuul
Branch: R1.10

commit 081ebc3878d5aa9c1987fb490e51e7b5b33e9f91
Author: Hampapur Ajay <email address hidden>
Date: Thu Jan 29 12:20:52 2015 -0800

config-autogen: generate sort operation outside for loop

List operations in scale tests are inefficient due to incorrect
position of sort call.

Change-Id: Id695a55a48945806cd477a1520731f45fb691c56
Closes-Bug: #1416089
(cherry picked from commit 74b8b44e456f529a06c26a5a91b33444752a2bd6)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/6792
Committed: http://github.org/Juniper/contrail-generateDS/commit/fc5fb97dc222595fd8f9b3510fd5d48b479b223a
Submitter: Zuul
Branch: R2.0

commit fc5fb97dc222595fd8f9b3510fd5d48b479b223a
Author: Hampapur Ajay <email address hidden>
Date: Thu Jan 29 12:20:52 2015 -0800

config-autogen: generate sort operation outside for loop

List operations in scale tests are inefficient due to incorrect
position of sort call.

Change-Id: Id695a55a48945806cd477a1520731f45fb691c56
Closes-Bug: #1416089
(cherry picked from commit 74b8b44e456f529a06c26a5a91b33444752a2bd6)

Changed in juniperopenstack:
importance: Undecided → Critical
assignee: nobody → Hampapur Ajay (hajay)
Revision history for this message
Nagabhushana R (bhushana) wrote :

I am marking this blocker to make sure we pick this for 2.1

tags: added: blocker config
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.