Hi,

looking at the compilation error '*utils\dropstats.c(138) : warning C4700:
uninitialized local variable 'ret' used*'.

I looked at change that your change depends on.

It looks like that change is also failing in Windows CI, probably for the
same reason.

Take a look at line 138 here:
https://review.opencontrail.org/#/c/47334/7/utils/dropstats.
<https://review.opencontrail.org/#/c/47334/7/utils/dropstats.c>

*ret* is initialized and but not assigned.

    int ret;
>     vr_pkt_drop_stats_log_request(cl, 0, core, stats_index);
>     if(ret <0)
>         return ret;


Not sure why you commented under this bug on launchpad though, as it seems
unrelated.

Best regards,

On Wed, Nov 21, 2018 at 11:35 AM haji mohamed ashraf ali <
<email address hidden>> wrote:

> Hi,
>
> Below build(After review creation) failed on Windows systems and I don’t
> have any clue what went wrong. I have checked the build on centos 7.4
> system, Build was passing.
>
> Request your help to fix the issue on windows based system.
>
> Review Id: https://review.opencontrail.org/#/c/47336/
> https://review.opencontrail.org/#/c/47334/
>
>
> Build Failure Log on Windows:
> light.exe -nologo -ext WixUtilExtension.dll -out
> build\debug\vrouter\extension\vRouter.msi
> vrouter\windows\installer\vrouter_msi.wixobj
> 2018-11-21 00:45:25.778000 | [Build] scons: building associated VariantDir
> targets: build\debug\vrouter\utils
> 2018-11-21 00:45:26.046000 | [Build] cl
> /Fobuild\debug\vrouter\utils\dropstats.obj /c vrouter\utils\dropstats.c
> /nologo /Iwindows/inc /D_WINDOWS /D_WIN32_WINNT=0x0A00 /EHsc /DNOMINMAX
> /DNOGDI /D_SCL_SECURE_NO_WARNINGS /D_CRT_SECURE_NO_WARNINGS
> /DWIN32_LEAN_AND_MEAN /RTC1 /MDd /Z7 /WX /Ivrouter\include
> /Ibuild\debug\vrouter\sandesh\gen-c /Ivrouter\sandesh\gen-c
> /Isrc\contrail-common /Isrc\contrail-common\sandesh\library\c
> /Ivrouter\windows
> 2018-11-21 00:45:26.046000 | [Build] dropstats.c
> 2018-11-21 00:45:26.315000 | [Build]
> j:\jenkins\workspace\wincontrail\****-server2016-prod\vrouter\utils\dropstats.c(138)
> : error C2220: warning treated as error - no 'object' file generated
> 2018-11-21 00:45:26.315000 | [Build]
> j:\jenkins\workspace\wincontrail\****-server2016-prod\vrouter\utils\dropstats.c(138)
> : warning C4700: uninitialized local variable 'ret' used
> 2018-11-21 00:45:26.315000 | [Build] scons: ***
> [build\debug\vrouter\utils\dropstats.obj] Error 2
>
> Please let me know, if any more details required.
>
> Regards
> Haji Mohamed.
>
>
> On 21/11/18, 2:37 PM, "Contrail Windows CI (Code Review)" <ci-
> <email address hidden>> wrote:
>
>     Contrail Windows CI has posted comments on this change.
>
>     Change subject: Vrouter drop stats log buffer Infra
>     ......................................................................
>
>
>     Patch Set 4: Verified-1
>
>     Build failed (check pipeline).
>
>     - ci-contrail-windows-production
> https://urldefense.proofpoint.com/v2/url?u=http-3A__logs.opencontrail.org_winci_30439a4a989e488aaba941bed53aba8f_&d=DwIDaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=C2uP7uRJxCXF0CJnbv4zz_BDg9aYeMnnEWdHkCYupeE&m=h4vCsMMc3kdUJuyQ34_gqXaPpS-S8T1q7aa5_17Jetw&s=IXP-tRHh0Yo1ZENO4DJ46doUavSJaz1BNreHaXbBtxU&e=
> : FAILURE in 35m 25s
>
>     This is a pipeline from Windows CI. Latest build stats:
> https://urldefense.proofpoint.com/v2/url?u=http-3A__148.251.5.92_d_w9YdWjqzk_build-2Dstatistics&d=DwIDaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=C2uP7uRJxCXF0CJnbv4zz_BDg9aYeMnnEWdHkCYupeE&m=h4vCsMMc3kdUJuyQ34_gqXaPpS-S8T1q7aa5_17Jetw&s=Bn5GFKdGHO_8t155VYviOBxHWd55PbV7RotOCyuhtuI&e=.
> For troubleshooting and FAQ, see:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Juniper_contrail-2Dwindows-2Dci_wiki_OpenContrail-2DWindows-2DCI-2DFAQ&d=DwIDaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=C2uP7uRJxCXF0CJnbv4zz_BDg9aYeMnnEWdHkCYupeE&m=h4vCsMMc3kdUJuyQ34_gqXaPpS-S8T1q7aa5_17Jetw&s=_ZaXWpn3s2XYM1Qz1GDYm5yEUCMSr_0nFnrSC2zqHvI&e=
>
>     --
>     To view, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__review.opencontrail.org_47336&d=DwIDaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=C2uP7uRJxCXF0CJnbv4zz_BDg9aYeMnnEWdHkCYupeE&m=h4vCsMMc3kdUJuyQ34_gqXaPpS-S8T1q7aa5_17Jetw&s=eNcwFP-WiI3sSedILqiXvLatZK5gAjt_fhj8uZsMeDg&e=
>     To unsubscribe, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__review.opencontrail.org_settings&d=DwIDaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=C2uP7uRJxCXF0CJnbv4zz_BDg9aYeMnnEWdHkCYupeE&m=h4vCsMMc3kdUJuyQ34_gqXaPpS-S8T1q7aa5_17Jetw&s=k5t9vKNAoJVsi-nwS2JNaTRKWwWUT6zx3L6qsxsiU2Q&e=
>
>     Gerrit-MessageType: comment
>     Gerrit-Change-Id: I146b650cdec968f15744ddd58fbdc4099a0752d3
>     Gerrit-PatchSet: 4
>     Gerrit-Project: Juniper/contrail-controller
>     Gerrit-Branch: master
>     Gerrit-Owner: haji mohamed ashraf ali <email address hidden>
>     Gerrit-Reviewer: Contrail Windows CI <<email address hidden>
> >
>     Gerrit-Reviewer: Kiran <email address hidden>
>     Gerrit-Reviewer: N Anand Rao <email address hidden>
>     Gerrit-Reviewer: Saurabh <email address hidden>
>     Gerrit-Reviewer: Zuul v3 CI <email address hidden>
>     Gerrit-Reviewer: haji mohamed ashraf ali <email address hidden>
>     Gerrit-Reviewer: opencontrail-admin <email address hidden>
>     Gerrit-HasComments: No
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1803015
>
> Title:
>   Insecure registry fails for windows nodes during configuration
>
> Status in Juniper Openstack:
>   New
>
> Bug description:
>
>   When private insecure registry is used for registry, the following error
> is observed for windows nodes,
>
>   global_configuration:
>     REGISTRY_PRIVATE_INSECURE: True
>     CONTAINER_REGISTRY: ci-repo.englab.juniper.net:5010
>
>   TASK [docker : create /etc/docker directory]
>   *****************************************************************
>
>    [WARNING]: FATAL ERROR DURING FILE TRANSFER: Traceback (most recent
> call last):   File "/usr/lib/python2.7
>   /site-packages/ansible/plugins/connection/winrm.py", line 276, in
> _winrm_exec
>   self._winrm_send_input(self.protocol, self.shell_id, command_id, data,
> eof=is_last)   File
>   "/usr/lib/python2.7/site-packages/ansible/plugins/connection/winrm.py",
> line 256, in _winrm_send_input
>   protocol.send_message(xmltodict.unparse(rq))   File
> "/usr/lib/python2.7/site-packages/winrm/protocol.py",
>   line 256, in send_message     raise WinRMOperationTimeoutError()
> WinRMOperationTimeoutError
>
>   fatal: [10.87.66.194]: FAILED! => {"msg": "winrm send_input failed"}
>
>   Using module file
> /usr/lib/python2.7/site-packages/ansible/modules/files/file.py
>   <10.87.66.192> ESTABLISH WINRM CONNECTION FOR USER: Administrator on
> PORT 5986 TO 10.87.66.192
>   Using module file
> /usr/lib/python2.7/site-packages/ansible/modules/files/file.py
>   <10.87.66.194> ESTABLISH WINRM CONNECTION FOR USER: Administrator on
> PORT 5986 TO 10.87.66.194
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juniperopenstack/+bug/1803015/+subscriptions
>


-- 

Michał Kostrzewa

Software Engineer, Team Leader

+48 500 067 670

<email address hidden>
<http://www.codilime.com/?utm_source=Stopka&utm_medium=Email&utm_campaign=Stopka>
<https://www.facebook.com/codilime/>
<https://www.linkedin.com/company/codilime>  <https://twitter.com/codilime>

CodiLime Sp. z o.o. - Ltd. company with its registered office in Poland,
02-493 Warsaw, ul. Krancowa 5.
Registered by The District Court for the Capital City of Warsaw,
XII Commercial Department of the National Court Register.
Entered into National Court Register under No. KRS 0000388871.
Tax identification number (NIP) 5272657478. Statistical number (REGON)
142974628.

-- 


-------------------------------
The information in this email is 
confidential and may be legally privileged, it may contain information that 
is confidential in CodiLime Sp. z o. o. It is intended solely for the 
addressee. Any access to this email by third parties is unauthorized. If 
you are not the intended recipient of this message, any disclosure, 
copying, distribution or any action undertaken or neglected in reliance 
thereon is prohibited and may result in your liability for damages.