Dependent links are not moved when node is moved in UpdateQ

Bug #1574448 reported by Nischal Sheth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Incomplete
Low
Prakash Bailkeri

Bug Description

Possible issue found by code inspection when chasing a different bug.

The following method should call GetUpdate on ls rather than state,
as state is the IFMapNodeState for the original node that was moved.
The purpose of this method is to move all the IFMapLinkStates for
the node.

void IFMapExporter::MoveDependentLinks(IFMapNodeState *state) {
    for (IFMapNodeState::iterator iter = state->begin();
         iter != state->end();
         ++iter) {
        IFMapLink *link = iter.operator->();
        IFMapLinkState *ls = LinkStateLookup(link);
        if (ls == NULL) {
            continue;
        }
        IFMapUpdate *update = state->GetUpdate(IFMapListEntry::UPDATE);
        if (update == NULL) {
            continue;
        }
        assert(!update->advertise().empty());
        queue()->Dequeue(update);
        queue()->Enqueue(update);
        sender()->QueueActive();
    }
}

Need to create a test for this scenario.

Nischal Sheth (nsheth)
description: updated
description: updated
Revision history for this message
Nischal Sheth (nsheth) wrote :

Since we no longer try to guarantee that agent will see nodes
before it sees a link connecting them, maybe we can just remove
the code instead of trying to fix it.

no longer affects: juniperopenstack/r2.20
no longer affects: juniperopenstack/r2.21.x
no longer affects: juniperopenstack/r2.22.x
no longer affects: juniperopenstack/r3.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.