validateCharmBaseWithName duplicates code in BaseSelector

Bug #2032639 reported by Jack Shaw
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Triaged
High
Jack Shaw

Bug Description

1) We are trying to move validation code off the client
2) We should only pass bases through which have been selected by a BaseSelector, which will do this validation for us

We should remove this method, replacing it with a BaseSelector where necessary
https://github.com/juju/juju/blob/1206b7da23628ec1b31cf5a22ec56c8a1c6c1ab9/cmd/juju/application/deployer/deployer.go#L700-L722

See further discussion here:
https://github.com/juju/juju/pull/16101#discussion_r1301431892

Jack Shaw (jack-shaw)
Changed in juju:
assignee: nobody → Jack Shaw (jack-shaw)
importance: Undecided → Low
importance: Low → Undecided
Changed in juju:
milestone: none → 3.3-beta2
Changed in juju:
status: New → Triaged
importance: Undecided → High
Changed in juju:
milestone: 3.3-beta2 → 3.3-rc1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.