Canonical Juju

Admin facade missing from schema

Bug #1885324 reported by Jeff Pihach
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
Simon Richardson
Canonical Juju 2.8.1

Bug Description

The schema (https://github.com/juju/juju/blob/d59b8637e150943cb987a8194addbdc116746b63/apiserver/facades/schema.json) is missing the Admin facade (https://github.com/juju/juju/blob/d59b8637e150943cb987a8194addbdc116746b63/apiserver/admin.go)

This is a blocker to us re-generating the js jujulib project from the new schema.

Revision history for this message
Heather Lanigan (hmlanigan) wrote :

Investigation shows they were never included. The schema generation didn't start at the apiserver directory, but lower.

Changed in juju:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Simon Richardson (simonrichardson) wrote :

It's currently not exposed[1] via the AllFacades, I question if it should be exposed from a security perspective (although it's only through obscurity that you can't access it)?

I think we should ask if we do expose it, why it's left off from the list of AllFacades. I'm unsure what the original intent was[2] and the commit message says nothing about the why?

1. https://github.com/juju/juju/blob/develop/apiserver/allfacades.go#L381-L400
2. https://github.com/juju/juju/commit/2183fbd2752baed4113f9eb690bdd0ed8b195daa

Revision history for this message
Jeff Pihach (hatch) wrote :

You also cannot use the API without the ability to log into it so it is kind of a requirement :D

Revision history for this message
Simon Richardson (simonrichardson) wrote :

PR: https://github.com/juju/juju/pull/11780/files

Changed in juju:
milestone: none → 2.8.1
assignee: nobody → Simon Richardson (simonrichardson)
status: Triaged → In Progress
status: In Progress → Fix Committed
Canonical Juju QA Bot (juju-qa-bot)
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.