kill-controller manual provider broken

Bug #1559701 reported by Ian Booth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
Unassigned

Bug Description

$ juju kill-controller mymanual
WARNING! This command will destroy the "local.mymanual" controller.
This includes all machines, services, data and other resources.

Continue [y/N]? y
Unable to destroy controller through the API: failed to destroy model: manually provisioned machines must first be destroyed with `juju destroy-machine 1`. Destroying through provider.

^^^^^^^ note the error message, should be "remove-machine"

$ juju remove-machine 1
ERROR no model specified
$ juju list-models
error: controller local.mymanual not found
$ juju list-controllers
CONTROLLER MODEL USER SERVER

The text "must first be destroyed" implies that something needs to be done in order to kill the controller. But it then says "Destroying through provisioner" and goes ahead and removes the local yaml files. But the manual machines still have the jujud agents running on them, so stuff has been left behind and needs manual cleanup.

tags: added: 2.0-count
Revision history for this message
Andrew Wilkins (axwalk) wrote :

This is the problem with "kill-controller". It's roughly the same as "destroy-environment --force", but with scary warnings and, IMO, less clear intent in the command name. To me, kill-controller just sounds like an alias for destroy-controller.

The --force used to imply that you were giving consent to tear away everything that the provider manages in an unfriendly way. That makes units aren't stopped, and manually provisioned machines aren't tidied up.

So what should we do? We could add another flag (-yy, "yes yes, I'm really sure")? Or educate people better? I personally think we should do away with kill-controller, and reintroduce --force.

Curtis Hovey (sinzui)
tags: added: manual-provider
Curtis Hovey (sinzui)
tags: added: manual-story
affects: juju-core → juju
Changed in juju:
milestone: none → 2.1.0
Changed in juju:
status: Triaged → Fix Committed
milestone: 2.1.0 → 2.0-beta18
Curtis Hovey (sinzui)
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.