Juju-lint requires landscape-server in saas

Bug #2033523 reported by Bas de Bruijne
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juju Lint
Fix Committed
Medium
Mert Kirpici

Bug Description

When running juju lint against the bundle attached using the command below, it reports that the landscape-server charm is missing.
~~~~~~
:~$ juju-lint -c /snap/juju-lint/current/contrib/fcb-yoga-jammy.yaml bundle.yaml
...
2023-08-30 11:49:55 [ERROR] [bundle.yaml] [manual/manual] Ops charm 'landscape-server' is missing
...
~~~~~~

The landscape-server charm doesn't relate to the landscape-client charm using juju relations but through manual charm configurations. There is no use in having landscape-server connect to the OpenStack model using saas.

Tags: bseng-1511

Related branches

Revision history for this message
Bas de Bruijne (basdbruijne) wrote :
Revision history for this message
Andrea Ieri (aieri) wrote :

Hi Bas, the bundle you have attached does not contain landscape (client or server). Perhaps you have uploaded the wrong bundle?

Changed in juju-lint:
status: New → Incomplete
Revision history for this message
Bas de Bruijne (basdbruijne) wrote :

Hi Andrea. Both landscape-client and server are indeed missing. Juju-lint throws an error for both of them. This error is correct for landscape-client, which should indeed be in the bundle.
I think the error is incorrect for landscape-server. Landscape-server should be in a different model and, unlike LMA and COS, does not need to show up in the saas applications of this bundle because landscape-server does not connect to the landscape-clients using juju relations.

Changed in juju-lint:
status: Incomplete → New
Eric Chen (eric-chen)
tags: added: bseng-1511
Changed in juju-lint:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Andrea Ieri (aieri) wrote :

Sorry Bas, I had misread your initial submission. Yes, you are correct that landscape-server should be in a separate model and that since it does not relate to landscape-clients[*], the error message you get is a false positive.

[*] there used to be a fork implementing registration between clients and server over a relation, but it never made it into the official codebase

Changed in juju-lint:
status: Triaged → In Progress
Changed in juju-lint:
assignee: nobody → Mert Kirpici (mertkirpici)
Revision history for this message
Mert Kirpici (mertkirpici) wrote :

A fix addressing this issue is available in the edge channel. Bas could you confirm the change fixes this issue?

Changed in juju-lint:
status: In Progress → Fix Committed
Revision history for this message
Bas de Bruijne (basdbruijne) wrote :

Thanks, Mert. The issue is indeed resolved.

Tianqi Xiao (txiao)
Changed in juju-lint:
milestone: none → 1.2.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.