Charm 'ubuntu-advantage' not recognised even though it's in includes/base.yaml

Bug #2032714 reported by Nobuto Murata
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juju Lint
Fix Committed
High
Andrea Ieri

Bug Description

$ snap list juju-lint
Name Version Rev Tracking Publisher Notes
juju-lint 1.1.0 105 latest/stable canonical✓ classic

1. juju deploy ./bundle.yaml
2. juju status --format json > juju-status.json
3. sudo snap install juju-lint --classic
4. juju-lint -c /snap/juju-lint/current/contrib/fcb-yoga-jammy.yaml juju-status.json

-> 2023-08-23 10:31:35 [ERROR] [juju-status.json] [manual/manual] Charm 'ubuntu-advantage' not recognised

Tags: bseng-1478

Related branches

Revision history for this message
Nobuto Murata (nobuto) wrote :
Revision history for this message
Nobuto Murata (nobuto) wrote :
Revision history for this message
Nobuto Murata (nobuto) wrote :
Revision history for this message
Nobuto Murata (nobuto) wrote :

Subscribing ~field-high.

Basically Juju-lint always errors out so the checks are tend to be ignored in the field or support when reviewing as it has too many false positives.

Eric Chen (eric-chen)
Changed in juju-lint:
importance: Undecided → High
status: New → Triaged
Eric Chen (eric-chen)
tags: added: bseng-1478
Andrea Ieri (aieri)
Changed in juju-lint:
status: Triaged → In Progress
assignee: nobody → Andrea Ieri (aieri)
Revision history for this message
Andrea Ieri (aieri) wrote :

The fix has been released in snap version 1.1.1.dev2+gcf207c1 (edge channel only for now)

Changed in juju-lint:
status: In Progress → Fix Committed
Revision history for this message
Samuel Walladge (swalladge) wrote :

Can confirm the bug is fixed with this patch. +1

Revision history for this message
Nobuto Murata (nobuto) wrote :

However, it now shows another error as "Application(s) has extraneous subordinate 'ubuntu-advantage'.

> 2023-08-28 00:16:44 [ERROR] [/tmp/juju-status-openstack.json] [manual/manual] Application(s) 'aodh, barbican, ceilometer, ceph-dashboard-loadbalancer, ceph-fs, ceph-mon, ceph-radosgw, cinder, designate, designate-bind, easyrsa, etcd, glance, glance-simplestreams-sync, gnocchi, heat, homer-dashboard, keystone, manila, manila-ganesha, memcached, mysql-innodb-cluster, neutron-api, nova-cloud-controller, octavia, openstack-dashboard, openstack-service-checks, ovn-central, placement, prometheus-openstack-exporter, rabbitmq-server' has extraneous subordinate 'ubuntu-advantage'

Looks like the code assumes that the ubuntu-advantage charm shouldn't be related to applications running in LXD containers. Although Pro token is not limited to livepatch but also additional security repositories and usg, etc.

I believe this is yet another false positive.

Nobuto Murata (nobuto)
Changed in juju-lint:
status: Fix Committed → Confirmed
Revision history for this message
Andrea Ieri (aieri) wrote :

@nobuto could you share the status file from the cloud where you see the false positive?

I have proposed a tentative fix but would like to confirm it works on your cloud before merging.

Changed in juju-lint:
status: Confirmed → In Progress
Andrea Ieri (aieri)
Changed in juju-lint:
status: In Progress → Fix Committed
Tianqi Xiao (txiao)
Changed in juju-lint:
milestone: none → 1.2.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.