Juju Lint

Getting many KeyError errors during spaces checks

Bug #1979382 reported by Vern Hart on 2022-06-22

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Juju Lint	Fix Released	Undecided	Gabriel Cocenza	Juju Lint 1.0.3

Bug Description

Running juju-lint on an exported bundle I get more than a dozen of these:

Exception caught during space check; please check space by hand. Traceback (most recent call last):
  File "/snap/juju-lint/current/lib/python3.8/site-packages/jujulint/lint.py", line 696, in check_spaces
    self._handle_space_mismatch(
  File "/snap/juju-lint/current/lib/python3.8/site-packages/jujulint/lint.py", line 725, in _handle_space_mismatch
    mismatch_relation = mismatch.get_charm_relation(self.model.app_to_charm)
  File "/snap/juju-lint/current/lib/python3.8/site-packages/jujulint/check_spaces.py", line 63, in get_charm_relation
    charm2 = app_to_charm_map[app2]
KeyError: 'prometheus'

It looks like these are related to CMR relations since all the applications mentioned in the KeyError are applications in a different model.

Full run attached.

Tags:

Related branches

~gabrielcocenza/juju-lint:bug/1979382

Merged into juju-lint:master at revision ca71a604c57b0c9641780b7cfa48d7e3a39d75c0

Martin Kalcok (community): Approve on 2022-07-20

Eric Chen: Approve on 2022-07-19

Revision history for this message

Vern Hart (vern) wrote on 2022-06-22:

juju-lint-errors.txt Edit (10.6 KiB, text/plain)

Revision history for this message

Vern Hart (vern) wrote on 2022-06-22:

Bundle Edit (61.4 KiB, text/plain)

Revision history for this message

Vern Hart (vern) wrote on 2022-06-22:

juju-lint.patch Edit (1.0 KiB, text/plain)

The attached patch uses the app_to_charm_map.get(app) method instead of app_to_charm_map[app] and ignores mismatches if one of the spaces is XModel (as set by the existing get_relation_space function).

Gabriel Cocenza (gabrielcocenza) on 2022-06-22