Ensure that unit tests and linters run on opened MPs
Bug #1978841 reported by
Martin Kalcok
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Juju Lint |
Fix Released
|
High
|
Mert Kirpici | ||
Bug Description
tox.ini file in the project contains environments for linting and running unit tests, however it's not enforced in launchpad when new Merge Proposal is opened.
We should connect this project to jenkins and ensure that any opened MPs pass unit tests and linter checks before they can be merged
Related branches
~gabrielcocenza/juju-lint:bug/1978739
- Martin Kalcok (community): Approve
- Eric Chen: Approve
-
Diff: 450 lines (+144/-58)19 files modified.pre-commit-config.yaml (+19/-0)
CONTRIBUTING.md (+14/-5)
Makefile (+48/-7)
contrib/fcb-stein-bionic.yaml (+1/-1)
contrib/fcb-ussuri-bionic-ovs.yaml (+1/-1)
contrib/fcb-ussuri-bionic.yaml (+1/-1)
contrib/fcb-ussuri-focal-ovs.yaml (+1/-1)
contrib/fcb-ussuri-focal.yaml (+1/-1)
contrib/fcb-yoga-focal.yaml (+1/-1)
contrib/includes/aggregator-kubernetes.yaml (+16/-0)
contrib/includes/release/stein.yaml (+1/-1)
contrib/includes/release/ussuri.yaml (+1/-1)
contrib/includes/release/yoga.yaml (+1/-1)
contrib/includes/series/focal.yaml (+1/-1)
contrib/kubernetes.yaml (+1/-17)
setup.py (+1/-1)
tests/requirements.txt (+2/-0)
tests/test_jujulint.py (+5/-0)
tox.ini (+28/-18)
| tags: | added: bseng-162 |
| Changed in juju-lint: | |
| importance: | Undecided → High |
| Changed in juju-lint: | |
| assignee: | nobody → Eric Chen (eric-chen) |
| Changed in juju-lint: | |
| status: | New → In Progress |
| milestone: | none → 1.0.4 |
| assignee: | Eric Chen (eric-chen) → Mert Kirpici (mertkirpici) |
Revision history for this message
| Gabriel Cocenza (gabrielcocenza) wrote | #1 |
| Changed in juju-lint: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
We are now running lint, unit and functional tests on opened Merge Proposal. Changing the status to fix released.