rsyslog upgrade step doesn't set LogDir
Bug #1284020 reported by
Andrew Wilkins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
Andrew Wilkins |
Bug Description
Our rsyslog configuration has a default log directory of /var/log/juju, but is overridden in machine configuration in environs/cloudinit. The upgrade step that rewrites configuration does *not* override the default, though, which will lead to the local provider writing to /var/log/juju instead of ~/.juju/local/log.
Related branches
lp://staging/~axwalk/juju-core/lp1281071-rsyslog-worker-tls
- Juju Engineering: Pending requested
-
Diff: 1452 lines (+1008/-32)27 files modifiedcmd/jujud/agent.go (+18/-0)
cmd/jujud/machine.go (+12/-0)
cmd/jujud/machine_test.go (+27/-0)
cmd/jujud/unit.go (+4/-0)
cmd/jujud/unit_test.go (+22/-0)
environs/cloudinit/cloudinit.go (+1/-0)
environs/config/config.go (+14/-2)
log/syslog/config.go (+73/-19)
log/syslog/config_test.go (+1/-0)
log/syslog/testing/syslogconf.go (+21/-4)
provider/local/config.go (+0/-1)
provider/local/environ.go (+9/-5)
state/api/params/params.go (+5/-0)
state/api/rsyslog/package_test.go (+14/-0)
state/api/rsyslog/rsyslog.go (+44/-0)
state/api/rsyslog/rsyslog_test.go (+35/-0)
state/api/state.go (+6/-0)
state/apiserver/root.go (+12/-0)
state/apiserver/rsyslog/package_test.go (+14/-0)
state/apiserver/rsyslog/rsyslog.go (+56/-0)
state/apiserver/rsyslog/rsyslog_test.go (+82/-0)
upgrades/rsysloggnutls.go (+14/-0)
upgrades/steps118.go (+5/-0)
upgrades/steps118_test.go (+2/-1)
worker/rsyslog/export_test.go (+12/-0)
worker/rsyslog/rsyslog_test.go (+248/-0)
worker/rsyslog/worker.go (+257/-0)
Changed in juju-core: | |
status: | Triaged → In Progress |
assignee: | nobody → Andrew Wilkins (axwalk) |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
milestone: | 1.18.0 → 1.17.4 |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is easily fixed by passing in the dataDir configured in the agent config to NewAccumulateCo nfig() and NewForwardConfig() functions and tweaking the templates