juju-core

File given to deploy --config is incompatible with pyjuju

Bug #1121907 reported by William Reade
36
This bug affects 6 people
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
William Reade
juju-core 1.11.2

Bug Description

The yaml file given to deploy --config <file.yaml> that pyjuju expects needs to have a key with the service name, while the one given to juju-core must not have such a key. For example, the landscape-client charm config:

pyjuju:
"""
landscape-client:
    url: https://landscape.canonical.com/message-system
"""

gojuju:
"""
url: https://landscape.canonical.com/message-system
"""

See original description
Tags: cmdline

Related branches

lp://staging/~fwereade/juju-core/config-5-state-service-config-yaml
Juju Engineering: Pending requested
Diff: 340 lines (+105/-53)
7 files modified
cmd/juju/config_test.go (+6/-7)
juju/conn_test.go (+9/-3)
state/apiserver/client_test.go (+5/-7)
state/apiserver/perm_test.go (+2/-2)
state/service.go (+40/-27)
state/service_test.go (+19/-5)
state/statecmd/deploy_test.go (+24/-2)
William Reade (fwereade)
tags: added: cmdline
Changed in juju-core:
importance: Undecided → High
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

The --config parameter is in the deploy documentation (juju deploy -h), but doesn't work.

William Reade (fwereade)
Changed in juju-core:
assignee: nobody → William Reade (fwereade)
Revision history for this message
Sidnei da Silva (sidnei) wrote :

Best I can tell, the problem is that the expected contents for the --config file are different between pyjuju and gojuju.

pyjuju expects (supports?) a top-level key that matches the service name such that you can have the config for all services into a single file, as in:

u1-3rdparty-fe:
    enable_modules: proxy rewrite proxy_http proxy_balancer ssl headers
    servername: 3rdpartymedia.ubuntuone.com
u1-public-fe:
    enable_modules: proxy rewrite proxy_http proxy_balancer ssl headers
    servername: ubuntuone.com

gojuju does not look for that top-level key, and instead expects the config settings to be at the top-level. as a result, if you have the service name at top-level, the config settings are ignored and no error is logged/printed. eg:

enable_modules: proxy rewrite proxy_http proxy_balancer ssl headers
servername: 3rdpartymedia.ubuntuone.com

Andreas Hasenack (ahasenack)
summary: - deploy --config
+ File given to deploy --config is incompatible with pyjuju
description: updated
William Reade (fwereade)
Changed in juju-core:
status: New → In Progress
William Reade (fwereade)
Changed in juju-core:
milestone: none → 1.11.1
status: In Progress → Fix Committed
Dave Cheney (dave-cheney)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.