Update pytest fixture for async functions
Bug #1983398 reported by
Tianqi Xiao
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Nagios Charm |
Fix Released
|
Undecided
|
Tianqi Xiao | ||
| Thruk Agent Charm |
Fix Released
|
Undecided
|
Tianqi Xiao | ||
| charm-advanced-routing |
Fix Released
|
Undecided
|
Mert Kirpici | ||
| charm-infra-node |
Fix Released
|
Undecided
|
Tianqi Xiao | ||
| charm-sysconfig |
Fix Released
|
Undecided
|
Tianqi Xiao | ||
| hw-health-charm |
Fix Released
|
Undecided
|
Robert Gildein | ||
| juju-autoreg |
New
|
Undecided
|
Unassigned | ||
| logrotate-charm |
Fix Released
|
Undecided
|
Tianqi Xiao | ||
Bug Description
Starting from `pytest-asyncio`'s most recent release (version 0.19.0), strict mode is enforced by default [1], which requires the usage of `@pytest.
For charms using pytest framework, we need to update their functional tests by replacing the current used `@pytest.fixture` with `@pytest_
[1]: https:/
[2]: https:/
Related branches
~mertkirpici/charm-advanced-routing:bseng/553
- 🤖 prod-jenkaas-bootstack: Needs Fixing (continuous-integration)
- Erhan Sunar (community): Approve
- Eric Chen: Approve
- BootStack Reviewers: Pending requested
-
Diff: 266 lines (+21/-101)6 files modifiedcharmcraft.yaml (+0/-4)
dev/null (+0/-71)
src/tests/functional/conftest.py (+13/-21)
src/tests/functional/requirements.txt (+2/-2)
src/tests/functional/test_routing.py (+4/-3)
src/wheelhouse.txt (+2/-0)
~rgildein/charm-hw-health:bug1983398
- Eric Chen: Approve
- BootStack Reviewers: Pending requested
-
Diff: 286 lines (+63/-58)4 files modifiedsrc/README.md (+1/-1)
src/tests/functional/conftest.py (+12/-9)
src/tests/functional/requirements.txt (+3/-4)
src/tests/functional/test_hwhealth.py (+47/-44)
~txiao/charm-sysconfig:pytest_fixture
- Eric Chen: Approve
- BootStack Reviewers: Pending requested
-
Diff: 97 lines (+10/-12)3 files modifiedsrc/metadata.yaml (+1/-5)
src/tests/functional/conftest.py (+5/-4)
src/tests/functional/test_deploy.py (+4/-3)
~txiao/charm-logrotated:pytest_fixture
- Eric Chen: Approve
- BootStack Reviewers: Pending requested
-
Diff: 90 lines (+9/-11)3 files modifiedsrc/metadata.yaml (+1/-5)
src/tests/functional/conftest.py (+5/-4)
src/tests/functional/test_logrotate.py (+3/-2)
~txiao/charm-thruk-agent:pytest_fixture
- Eric Chen: Approve
- BootStack Reviewers: Pending requested
-
Diff: 168 lines (+16/-16)3 files modifiedmetadata.yaml (+0/-1)
tests/functional/conftest.py (+12/-11)
tests/functional/test_deploy.py (+4/-4)
~txiao/charm-nagios:pytest_fixture
- Eric Chen: Approve
- Robert Gildein: Approve
- BootStack Reviewers: Pending requested
-
Diff: 238 lines (+26/-24)2 files modifiedtests/functional/conftest.py (+17/-16)
tests/functional/test_config.py (+9/-8)
~txiao/charm-infra-node:xenial/stable
- Eric Chen: Approve
- Robert Gildein: Approve
-
Diff: 47 lines (+5/-3)2 files modifiedsrc/tests/functional/test_deploy.py (+4/-3)
src/wheelhouse.txt (+1/-0)
~txiao/charm-infra-node:jammy-support
- Eric Chen: Approve
- BootStack Reviewers: Pending requested
-
Diff: 95 lines (+13/-11)3 files modifiedcharmcraft.yaml (+4/-4)
src/metadata.yaml (+1/-1)
src/tests/functional/test_deploy.py (+8/-6)
| description: | updated |
| Changed in charm-infra-node: | |
| status: | New → In Progress |
| Changed in charm-nagios: | |
| status: | New → Fix Committed |
| status: | Fix Committed → In Progress |
| assignee: | nobody → Tianqi Xiao (txiao) |
| Changed in charm-thruk-agent: | |
| status: | New → In Progress |
| assignee: | nobody → Tianqi Xiao (txiao) |
| Changed in charm-infra-node: | |
| status: | In Progress → Fix Committed |
| Changed in charm-nagios: | |
| status: | In Progress → Fix Committed |
| Changed in charm-thruk-agent: | |
| status: | In Progress → Fix Committed |
| no longer affects: | charm-advanced-routing |
| Changed in charm-logrotated: | |
| status: | New → In Progress |
| assignee: | nobody → Tianqi Xiao (txiao) |
| Changed in charm-logrotated: | |
| status: | In Progress → Fix Committed |
| Changed in charm-sysconfig: | |
| status: | New → In Progress |
| assignee: | nobody → Tianqi Xiao (txiao) |
| Changed in charm-sysconfig: | |
| status: | In Progress → Fix Committed |
| Changed in charm-hw-health: | |
| assignee: | nobody → Robert Gildein (rgildein) |
| status: | New → In Progress |
| Changed in charm-hw-health: | |
| status: | In Progress → Fix Committed |
| Changed in charm-infra-node: | |
| milestone: | none → 22.08 |
| Changed in charm-sysconfig: | |
| milestone: | none → 22.08 |
| Changed in charm-hw-health: | |
| milestone: | none → 22.08 |
| Changed in charm-logrotated: | |
| milestone: | none → 22.08 |
| Changed in charm-sysconfig: | |
| status: | Fix Committed → Fix Released |
| Changed in charm-infra-node: | |
| status: | Fix Committed → Fix Released |
| Changed in charm-hw-health: | |
| status: | Fix Committed → Fix Released |
| Changed in charm-logrotated: | |
| status: | Fix Committed → Fix Released |
| Changed in charm-thruk-agent: | |
| milestone: | none → 22.10 |
| Changed in charm-nagios: | |
| milestone: | none → 22.10 |
| Changed in charm-thruk-agent: | |
| status: | Fix Committed → Fix Released |
| Changed in charm-nagios: | |
| status: | Fix Committed → Fix Released |
| Changed in charm-advanced-routing: | |
| assignee: | nobody → Mert Kirpici (mertkirpici) |
| status: | New → In Progress |
| Changed in charm-advanced-routing: | |
| status: | In Progress → Invalid |
| tags: | added: good-first-bug |
| Changed in charm-advanced-routing: | |
| status: | Invalid → Fix Committed |
| Changed in charm-advanced-routing: | |
| milestone: | none → 23.01 |
| Changed in charm-advanced-routing: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
