Session D-BUS call search_driver() should return list of files

Bug #269311 reported by Martin Pitt
4
Affects Status Importance Assigned to Milestone
Jockey
Fix Released
Critical
Martin Pitt
jockey (Ubuntu)
Fix Released
Critical
Martin Pitt

Bug Description

As discussed with Tim Waugh and Till, the search_driver() call should return a list of installed files from the packages, not just True/False. This makes it much more useful for programs like s-c-p.

Revision history for this message
Martin Pitt (pitti) wrote :

Since this is an API change, it is a blocker for 0.5.

Changed in jockey:
assignee: nobody → pitti
importance: Undecided → Critical
milestone: none → 0.5
status: New → In Progress
Changed in jockey:
assignee: nobody → pitti
importance: Undecided → Critical
milestone: none → ubuntu-8.10-beta
Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in trunk, r424.

Changed in jockey:
status: In Progress → Fix Committed
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jockey - 0.5~alpha1-0ubuntu5

---------------
jockey (0.5~alpha1-0ubuntu5) intrepid; urgency=low

  * Merge bug fixes from trunk:
    - Fix XorgDriverHandler to not be "used" right after enabling.
    - Make sure that dri2 is not disabled for fglrx, it crashes amdcccle. (LP:
      #273320) [Alberto]
    - Use a "refresh" icon for drivers where a reboot needs to happen.
      (LP: #272238) [Alberto]
    - Fix KDE notification and the related test. Work around segfault when
      exiting the KDE UI. (LP: #270522) [Alberto]
    - search_driver(): Return list of installed files in addition to status
      code. Document the return value in README.txt. (LP: #269311)
    - Converts search_driver() printer device ID to friendly string (only
      supports printers for now). (part of LP #269454)
    - Do not make a backup of xorg.conf if the proprietary driver is already
      set there, so that we don't automatically revert to a configuration with
      the proprietary driver after uninstalling exactly that. [Alberto]

 -- Martin Pitt <email address hidden> Wed, 24 Sep 2008 22:40:22 +0200

Changed in jockey:
status: In Progress → Fix Released
Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

Reopening as the API change of search_driver() still does not work due to the output data types profile not being set. See attached patch for a fix.

This must be fixed for the beta, as I have uploaded system-config-printer with activated Jockey call already.

Changed in jockey:
status: Fix Released → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jockey - 0.5~alpha1-0ubuntu6

---------------
jockey (0.5~alpha1-0ubuntu6) intrepid; urgency=low

  * jockey/ui.py: Fixed output signature of search_driver() method, to really
    fix LP: #269311.

 -- Till Kamppeter <email address hidden> Thu, 25 Sep 2008 10:28:44 +0200

Changed in jockey:
status: Triaged → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in upstream release 0.5beta1.

Changed in jockey:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.