HEK-Popup appearence suboptimal

You are right - the screenshot looks horrible. Thats not really the case on a mac.

- Does anyone have experience in chosing the right font size in a text/html panel? I'm not quite sure how to achieve a common font size.

- I chose the short "field_name" for the URL title, since multiple links are displayed if available. A long title would not allow the links to fit into the window.

I submitted a patch to this problem:

Previously JWindow was used to display the dialog (some heritage of the very first event plugin).
Now HEK uses JFrame to display event popups:
This should fix the Windows related problems (+ even looks and feels better on a mac).

In addition, I changed the resizing behavior: See screenshots.

On Windows, it looks better for the moment, although there are still some issues left:

1) Two different font styles are used, causing a weird offset (see attached screenshot)
2) Using JFrame, the window can be maximized and minimized, which does not really make sense here...
3) Using JFrame, it is possible to move the window around. Doing so, the relation between the window and the event is not very obvious any more, which should be prevented.
4) Using JFrame, the window is displayed in the task bar (see attached screenshot), which does not make sense here. This is an info popup inside JHV, it is not an own component.
5) Something I haven't considered before: Before displaying the frame/window/whatever, its position should be verified. Now, it may be off-screen (see attached screenshot), which is also suboptimal.

All in all, I don't think that using JFrame is such a good idea - see above. In my opinion, fixing the issues using JWindow (for example by adding a border) is the better solution.

Thanks for the comments. I understand the points you mentioned. On the other hand, I really like the native window layout. As a new try, I switched to JDialog which removes the problems you mentioned:

1) The fonts should harmonize now. Could you check that?
2) Switched to JDialog
3) The currently displayed event is now highlighted by an enlarged event icon.
4) Switched to JDialog
5) This is still open.

Could you retry the latest HEK version on windows?

I just checked the current version:

1) Some fonts are correct, others are not (see attached screenshot). Also, the offset between the caption and the contents of a field is still present.
2) Fixed
3) I really like the idea of the enlarged icon, good work!
4) Fixed
5) I know, I never solved that issue for the old event interface either. Maybe we can open a new bug for this when everything else about the appearance is fixed.

Hi Malte,

Thanks for tackling these issues. I also like the enlarged icon a lot and would agree with Markus to open a new bug for 5).
@Markus: Can the top bar of a pop-up window be outside the visible screen area? On OS X, this does not seem to happen (the menu bar is a "natural" border). If we can avoid situations in which the user can't get the window to where he wants it to be, I would suggest releasing a JHV update containing the HEK-plugin improvements + Markus's various upgrades (HMI support, L&F improvements etc.) rather soon. @Malte+Markus: What do you think?

Cheers,

On 21. 2.2011, at 9:19 , Markus Langenberg wrote:

> I just checked the current version:
>
> 1) Some fonts are correct, others are not (see attached screenshot). Also, the offset between the caption and the contents of a field is still present.
> 2) Fixed
> 3) I really like the idea of the enlarged icon, good work!
> 4) Fixed
> 5) I know, I never solved that issue for the old event interface either. Maybe we can open a new bug for this when everything else about the appearance is fixed.
>
> ** Attachment added: "HEKPopUpBetterButStillSuboptimal.png"
> https://bugs.launchpad.net/jhelioviewer/+bug/690554/+attachment/1863674/+files/HEKPopUpBetterButStillSuboptimal.png
>
> --
> You received this bug notification because you are a member of
> JHelioviewer Developers, which is subscribed to JHelioviewer.
> https://bugs.launchpad.net/bugs/690554
>
> Title:
> HEK-Popup appearence suboptimal
>
> Status in JHelioviewer - JPEG2000 Visualization Software:
> Confirmed
>
> Bug description:
> At least on Windows, the appearance of the HEK popup should be
> improved (see screenshot):
>
> - Add a border to separate it from the background
> - Increase the size of the close button, to fit the icon
> - Decrease font size for the hyperlink, to fit the rest of the dialog
> - Maybe rename hyperlink so something more meaningful (the target?)

Hi *,

I will fix (1) soon.

After this is done (and if you guys think (5) is not too urgent) we can (in my opinion) push out a new release.

Cheers,
Malte

Since guessing what might went wrong on windows, I fixed the remaining issues (1 and 5) myself. Talking about (5): There already was a logic for positioning the pop up from the previous version. Since the pop up might be much bigger now, the given logic was not enough or even caused more problems than not using it at all. I improved the logic in a way, that the pop up always stays inside the image panel, apart from the case: The left border of the image panel may be breached to prevent hiding the event icon by the pop up.