Ironic

Ironic conductor does not validate ipmi_address URLs

Bug #1666223 reported by M V P Nitesh
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
In Progress
Wishlist
Seamanhanshan

Bug Description

When user does "ironic node-validate <node-uuid>", ironic conductor does not validate the ipv4 address. The ip address entered by the user should be a valid ip address. At the time of node-updation, characters are accepted as part of ip-address and when user does the node-validation it succeeds.

Tags: ironic
M V P Nitesh (m-nitesh)
Changed in ironic:
assignee: nobody → M V P Nitesh (m-nitesh)
Revision history for this message
Vladyslav Drok (vdrok) wrote :

What do you mean by ipv4 address? The node does not have an ip address field. Please add more information about the issue.

Changed in ironic:
status: New → Incomplete
Revision history for this message
Michael Turek (mjturek) wrote :

Hello m-nitesh:

Are you referring to validation of the BMC/HMC address? (ie - for the agent_ipmitool driver this would be the 'ipmi_address')

Or maybe the agent_url?

Either way these are not necessarily IPs. I'd like some more info.

Michael Turek (mjturek)
Changed in ironic:
importance: Undecided → Wishlist
Revision history for this message
M V P Nitesh (m-nitesh) wrote :

Hi Michael Turek:

I'm referring to ipmi_address which updated in the node. Suppose if we add ipmi_address as "123.233.342.123"(which is not a valid IP address) or "dfk-dfkl_kdfs.com"(which is not a valid host name) when the user does "ironic node-validate <node-name>" it should throw error stating user has updated the invalid ipmi_address

Michael Turek (mjturek)
Changed in ironic:
status: Incomplete → Triaged
summary: - Ironic conductor does not validate the ipv4 address
+ Ironic conductor does not validate ipmi_address URLs
Changed in ironic:
status: Triaged → Confirmed
Revision history for this message
Seamanhanshan (yaojun) wrote :

hello MVPN, just as we talked in IRC, i'll assign this bug to me, thanks!

Changed in ironic:
assignee: M V P Nitesh (m-nitesh) → Seamanhanshan (yaojun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/465866

Changed in ironic:
status: Confirmed → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.