Add additional hacking checks (similar to Nova and Neutron)

Bug #1533474 reported by Kan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Triaged
Wishlist
ChangBo Guo(gcb)
Ironic Inspector
Triaged
Wishlist
Unassigned
python-ironicclient
Triaged
Wishlist
Kan

Bug Description

Hacking project provides common code style check, but there could be some additional checks for pep8 tests. For example, if we want to assert if a argument is mutable, we can add hacking checks to enhance it.

Add hacking support like neutron and nova does:
https://github.com/openstack/neutron/blob/master/neutron/hacking/checks.py
https://github.com/openstack/nova/blob/master/nova/hacking/checks.py

Tags: testing
Kan (kansks)
Changed in ironic:
assignee: nobody → Kan (kansks)
description: updated
Kan (kansks)
Changed in python-ironicclient:
assignee: nobody → Kan (kansks)
Kan (kansks)
description: updated
description: updated
Revision history for this message
Dmitry Tantsur (divius) wrote :

Hi! That's not a feature, so I'm dropping RFE tag. Also please make sure that whatever solution for this problem is, it does not involve copying files from neutron, we need to use some common location.

summary: - [RFE]Add hacking support
+ Add additional hacking checks (similar to Nova and Neutron)
tags: added: testing
removed: rfe
Changed in ironic:
status: New → Triaged
importance: Undecided → Wishlist
Changed in python-ironicclient:
status: New → Triaged
importance: Undecided → Wishlist
Changed in ironic-inspector:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Ruby Loo (rloo) wrote :

Before you go to whatever work to make these changes, the bug doesn't describe (In English words) what the hacks are. Maybe ironic doesn't want any/all of them. I don't know what N320 etc are.

description: updated
Changed in ironic:
assignee: Kan (kansks) → ChangBo Guo(gcb) (glongwave)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/380735

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by ChangBo Guo(gcb) (<email address hidden>) on branch: master
Review: https://review.openstack.org/380735
Reason: Ruby loo, thanks for your declaration

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.