Mis-formatted calls to log.* are not detected in unit tests

Hi! This is a valid bug, but it's not a bug in ironic, so I suggest we track it in #1503049

I don't believe this is a duplicate. I have patched fixtures to report the exception but I still can't get log messages to fail.

In my testing, the fake logger does not seem to be getting used during the Ironic unit tests. So I am confused.

In particular I was trying:
tox -v -v -epy27 -- -r 'test_configure_local_boot$' --serial

And did some hacking to fixtures/_fixtures/logger.py to have it write to files when the FakeLogger gets used. I only see one use of it and that appears to be for alembic.

Will continue to troubleshoot.

One thing I noticed is that when doing:
$ tox -v -v -epy27 -- -r 'test_configure_local_boot$' --serial

The LOG does not have the FakeLogger as a handler.

I discovered this by doing a:
  raise ValueError(LOG.handlers)

in the called function.

My suspicion is that doing logger.getlogger(__name__) gets a different logger.

But even when I setup the FakeLogger, I still don't get a failure. I started doing some pdb work on it and will continue tomorrow.

Comment 4 was a red herring. Actually tracked it down to something else. I have submitted a patch.

This is patch:

https://review.openstack.org/232257

Fix proposed to branch: master
Review: https://review.openstack.org/511066

Change abandoned by "John L. Villalovos <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/232257

Change abandoned by "John L. Villalovos <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ironic-python-agent/+/511066

Change abandoned by "Jay Faulkner <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ironic-python-agent/+/511066
Reason: this needs more than a rebase, and I don't have time to attack it