Make sure one can restart discoverd while waiting for longer stuff

Bug #1421678 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic Inspector
Triaged
Low
Unassigned

Bug Description

Includes restart when:
- waiting for manual power on - likely not needed
- waiting for power off after inspection - FIXED
- waiting for credentials setup - TODO

Update:
- Stop checking for power off, we can trust Ironic in ability of doing it

Dmitry Tantsur (divius)
Changed in ironic-discoverd:
importance: Medium → High
Dmitry Tantsur (divius)
description: updated
Changed in ironic-discoverd:
assignee: nobody → Dmitry "Divius" Tantsur (divius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-discoverd (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165062

Changed in ironic-discoverd:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-discoverd (master)

Reviewed: https://review.openstack.org/165062
Committed: https://git.openstack.org/cgit/stackforge/ironic-discoverd/commit/?id=14a8ce58dc779b4448a394afd56701f49bdcb635
Submitter: Jenkins
Branch: master

commit 14a8ce58dc779b4448a394afd56701f49bdcb635
Author: Dmitry Tantsur <email address hidden>
Date: Tue Mar 17 14:14:20 2015 +0100

    Stop waiting for power off to happen after introspection

    There is no reason not to trust Ironic in doing its job, and
    this wait loop will cause false negative, if service restart
    happens in the middle.

    Also move call to finished() before updating node.extra with
    newly_discovered for the same reason.

    Change-Id: I601b2660635783c8f0c59e17ca3392c347eafa53
    Partial-Bug: #1421678

Dmitry Tantsur (divius)
description: updated
Changed in ironic-discoverd:
status: In Progress → Triaged
assignee: Dmitry "Divius" Tantsur (divius) → nobody
milestone: 1.1.0 → none
Dmitry Tantsur (divius)
Changed in ironic-discoverd:
milestone: none → 1.2.0
Dmitry Tantsur (divius)
Changed in ironic-inspector:
milestone: 2.0.0 → 2.1.0
Dmitry Tantsur (divius)
Changed in ironic-inspector:
importance: High → Low
milestone: 2.1.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.