IrcClient.HandleISupportParameter throws when connecting to irc.webchat.org due to a missing paramName parameter
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
IRC.NET |
New
|
Undecided
|
Unassigned |
Bug Description
Here's the stacktrace, which doesn't really do anything other than point to the method:
at IrcDotNet.
at IrcDotNet.
at IrcDotNet.
at IrcDotNet.
at System.
at System.
at System.
at System.
at System.
at System.
at System.
at System.
at System.
at System.
at System.
Webchat isn't a normal network in that it mostly uses ConferenceRoom which doesn't seem to conform to RFC standards most of the time. I can't tell if the problem is it's passing in empty paramNames just once every single time it's called.
What happens for the connection is the client triggers Connected and Registered events but it is NOT getting to NetworkInformat
I'd also question using a hard throw in this instance for HandlesISupport
Lastly, I read the Error event more as a FatalException where IrcDotNet cannot do anything else for the client that raises it. If this is false, perhaps introducing an IsHandled property in IrcErrorEventArgs where internal methods set this to true. This would let me easily distinguish IrcDotNet errors versus what I normally see which are exceptions in my code that bubble up.