DXF import misses out the last line

The following patch double-checks the vals array, and sees if there's any left over data. If so, it outputs the missing last line.

Missing path of attached DXF file reproduced with Inkscape 0.48.1 and 0.48+devel r10118 on OS X 10.5.8 (i386)
(drawing content compared to rendering in QCad, DraftSight and SolidWorks eDrawings)

It appears to be the last path according to the stack order in Inkscape - I didn't verify this with external applications.

thanks, I'll check it out on the weekend

Alvin

@Alvin - assigning this report to you: the patch didn't apply for me to current trunk (for testing). It would be great if you could take a look since you certainly have more insight into the current state and workings of 'dxf_input.py' than anyone else.

Please revert to 'Nobody' if you prefer not having reports assigned to you.

As far as I can tell, the file single.grid-plans is from AutoCad Release 10, based on the parameter ACADVER = AC1006. The Inkscape input routine supports only Release 13 and newer, which is the reason for the missing last line segment. The file is not viewable in Voloview Express 2.01 which is my favorite tool for checking syntax.

I would recommend loading this into QCad and then saving it. (The default save format for QCad is Release 13). I get the attached dxf file if I do this with QCad 2.1.3.2. This file is viewable in Voloview Express and appears to load properly into Inkscape, as far as I can tell.

hth,
Alvin

So, strictly speaking single.grid-plans.dxf isn't from any release of AutoCad. It's a generated file from a modified version of the SDXF library (http://www.kellbot.com/sdxf-python-library-for-dxf/). I could change the version code that I'm spitting out, but I don't think that'll fix things. As far as I can tell, the QCad-saved version has a bunch of other items after the last LINE, so you don't see any problems with Inkscape as the item it misses things off of doesn't get rendered anyway. OTOH, single.grid-plans.dxf ends almost immediately after the last line segment, and so that gets missed off.

One thing that might potentially help is if it's identified that there's some part of the DXF format that Inkscape doesn't like, but given LINE has been in there for ages, I doubt that's the problem.

attached is a modified version of the file dxf_input.py. I have replaced the entity called DICTIONARY with one called EOF. This is used as a flag to indicate when to stop processing. With this change the file single.grid-plans.dxf reads in properly as far as I can tell.

Looks good to me. Just tested this both against single.grid-plans, and a couple of other similar files. All look fixed now. Thanks!

good to hear, committed to bzr rev 10131

Backported in the branch, revision 9811.