build fails on win32, at filedialogimpl-win32.cpp

Bug #616589 reported by Mat
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Critical
Jon A. Cruz

Bug Description

Hi, I encountered a compile error under win32:

src/ui/dialog/filedialogimpl-win32.cpp: In function 'int Inkscape::UI::Dialog::<unnamed>::sanitizeWindowSizeParam(int, int, int, int)':
src/ui/dialog/filedialogimpl-win32.cpp:103:17: error: 'lower' was not declared in this scope
src/ui/dialog/filedialogimpl-win32.cpp: At global scope:
src/ui/dialog/filedialogimpl-win32.cpp:100:5: warning: unused parameter 'minimum'
src/ui/dialog/filedialogimpl-win32.cpp: In static member function 'static UINT_PTR Inkscape::UI::Dialog::FileSaveDialogImplWin32::GetSaveFileName_hookproc(HWND__*, UINT, WPARAM, LPARAM)':
src/ui/dialog/filedialogimpl-win32.cpp:1735:74: warning: passing NULL to non-pointer argument 1 of 'HWND__* CreateWindowExA(DWORD, const CHAR*, const CHAR*, DWORD, int, int, int, int, HWND__*, HMENU__*, HINSTANCE__*, void*)'

( detail is in attachment )

The build environment is:

OS=> Windows7, 32-bits
revno => 9701 from trunk

build step is the same as webpage:
http://wiki.inkscape.org/wiki/index.php/Win32Port

Tags: build win32
Revision history for this message
Mat (matlinuxer2) wrote :
su_v (suv-lp)
tags: added: build win32
Revision history for this message
su_v (suv-lp) wrote :

Related to revision 9698 - it seems an older version of the patch for bug #285267was committed: until fixed, you can revert 'src/ui/dialog/filedialogimpl-win32.cpp' to revision 9697 and apply the patch from <https://bugs.launchpad.net/inkscape/+bug/285267/comments/38> - it should compile without error then.

Changed in inkscape:
importance: Undecided → Critical
status: New → Confirmed
assignee: nobody → Jon A. Cruz (jon-joncruz)
milestone: none → 0.48
status: Confirmed → In Progress
Changed in inkscape:
status: In Progress → Fix Committed
Revision history for this message
Mat (matlinuxer2) wrote :

Verified.
The compilation has pass that point.
Many Thanks!

jazzynico (jazzynico)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.