[pencil tool] dots are created with wrong cy value (GUI instead of SVG coordinate system)

For me, this fixes it:

=== modified file 'src/draw-context.cpp'
--- src/draw-context.cpp 2010-01-23 13:36:56 +0000
+++ src/draw-context.cpp 2010-06-22 21:58:53 +0000
@@ -837,7 +837,7 @@
     Inkscape::Preferences *prefs = Inkscape::Preferences::get();

     Geom::Matrix const i2d (sp_item_i2d_affine (item));
- Geom::Point pp = pt;
+ Geom::Point pp = pt * i2d.inverse();
     double rad = 0.5 * prefs->getDouble(tool_path + "/dot-size", 3.0);
     if (event_state & GDK_MOD1_MASK) {
         /* TODO: We vary the dot size between 0.5*rad and 1.5*rad, where rad is the dot size
@@ -856,7 +856,6 @@
     sp_repr_set_svg_double (repr, "sodipodi:rx", rad * stroke_width);
     sp_repr_set_svg_double (repr, "sodipodi:ry", rad * stroke_width);
     item->updateRepr();
- sp_item_set_item_transform(item, i2d.inverse());

     sp_desktop_selection(desktop)->set(item);

fixed in r9529

Changing status to 'Fix Released' in accordance to <http://wiki.inkscape.org/wiki/index.php/Bug_management#Bug_status> because the bug only existed in the development branch and not in the current stable release.

Misinterpretation on my part, sorry.

Reopening - this error re-occurs in current trunk when
- duplicating a dot
- grouping a dot

I don't know what happened, but it seems as if the fix in revision 9529 is no longer effective somehow.

(tests with archived versions indicate that a change between 9944 and 9950 caused the regression:
- 9944: duplicating or grouping dots is still ok
- 9950: duplicated or grouped dots are transformed to mirrored y-position
possibly triggered by the changes in the C++-ification merge in revision 9946)

Reproduced with Inkscape 0.48+devel r10195 on OS X 10.5.8 (i386) and earlier revisions (up to 9950),
confirmed by ScislaC with current trunk on Ubuntu.

Reproduced on Windows XP, trunk revision 11652.

Apparently the change committed by Johan was overwritten by the c++ification (see http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/9946#src/draw-context.cpp).
I've tested the patch from comment #1 (with a minor change to fit the trunk), and it looks good, at least on Windows XP.

Attaching an updated version of the patch that works with revision 11652.

Fix committed in the trunk , revision 11653.

@Kris - The bug affected the trunk version only, not the released 0.48.x branch. In that case, we should not set a milestone.

@JazzyNico: indeed, I overlooked this one and did not remove the milestone of another one after I noticed it was fix released and not fix committed. Sorry ;-)