Inkscape

parseColor() in simplestyle.py can't parse colors of type rgb(xx.x%,xx.x%,xx.xx%)

Bug #298528 reported by Kjell Magne Fauske on 2008-11-15

Affects		Status	Importance	Assigned to	Milestone
	Inkscape	Fix Released	Low	Kjell Magne Fauske	Inkscape 0.48.3

Bug Description

The parseColor() function in simplestyle.py can't parse valid color expressions like:

parseColor('rgb(66.667%,0%,6.667%)')
parseColor('currentColor')
parsecolor('ActiveBorder')

I have attached a patch that fixes the first problem. I have also attached unit tests that verifies it.

For the two other color types there is no straightforward solution since resolving the color code requires knowledge of the environment. A workaround is to return a default color, but it is not an ideal solution.

Tags:

Related branches

lp://staging/~inkscape.dev/inkscape/trunk

lp://staging/inkscape/0.48.x

Revision history for this message

Kjell Magne Fauske (kjellmf) wrote on 2008-11-15:

Adds parsing of rgb(xx.xx%,xx.xx%,xx.x%) to parseColor Edit (567 bytes, text/plain)

Revision history for this message

Kjell Magne Fauske (kjellmf) wrote on 2008-11-15:

Unit tests for parseColor() Edit (1.6 KiB, text/x-python)

Revision history for this message

Kjell Magne Fauske (kjellmf) wrote on 2008-11-15:

Patch for returning a default color when color is unknown Edit (710 bytes, text/plain)

I have attached a patch that return a default color (black) in cases where the color is unknown. Not sure if this is the best approach, but it is probably better than raising an exception.

Pablo Trabajos (pajarico) on 2009-08-15

tags:

added: extensions-plugins
removed: extensions

jazzynico (jazzynico) on 2011-09-01

Changed in inkscape:
assignee:	nobody → JazzyNico (jazzynico)
importance:	Undecided → Low
milestone:	none → 0.49
status:	New → In Progress

Revision history for this message

jazzynico (jazzynico) wrote on 2011-09-01:

Fix committed in the trunk, revision 10610.
Thanks for the patches and the test file (committed as well in the test directory).

As you noticed in the bug description, currentColor and ActiveBorder are very difficult to parse here. I'm going to close the reoort because it fixes what can be fixed with numerical values. Feel free to open a different report for the remaining issues.

Changed in inkscape:
assignee:	JazzyNico (jazzynico) → Kjell Magne Fauske (kjellmf)
status:	In Progress → Fix Committed
tags:	added: backport-proposed color styles removed: python