The "_dpi" field/member-var in CairoRenderContext is not used.

Bug #1614620 reported by Shlomi Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
New
Low
Unassigned

Bug Description

The "_dpi" field/member-var in CairoRenderContext is not used. Why is it there? I'll soon attach a patch that removes it, and with it all tests pass in "ninja check" and inkscape seems to run fine. Someone on IRC was grepping the code for "dpi" and thought it was used so it is misleading.

Tags: code-design
Revision history for this message
Shlomi Fish (shlomif-gmail) wrote :
su_v (suv-lp)
tags: added: code-design
Revision history for this message
Bryce Harrington (bryce) wrote :

You might look and see if it would also need to be removed from the config xml in cairo-ps-out.cpp, cairo-ps-out.cpp, and cairo-renderer-pdf-out.cpp?

Revision history for this message
Shlomi Fish (shlomif-gmail) wrote :

@bryce : you mentioned "cairo-ps-out.cpp" twice. Did you mean two different files?

jazzynico (jazzynico)
Changed in inkscape:
importance: Undecided → Low
milestone: none → 0.93
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.