click twice to select objects in root layer

On OS X 10.7.5, with default prefs, based on provided steps to reproduce and test file:
- not reproduced with Inkscape 0.48.5
- not reproduced with 0.91pre2 r13527

Note: when opening the file, 'root' is already the current drawing level (see status bar layer indicator): a single click is sufficient to select the object.

The need to click a second time happens if the current layer is one of the regular layers (not 'root'): the first click changes the drawing level to 'root' (see layer indicator in the status bar), the second click selects the path in the current drawing level 'root'.

'click twice' needed if current layer ≠ 'root':
- reproduced with stable 0.48.2, 0.48.3, 0.48.4, 0.48.5
- reproduced with 0.91pre2 r13527.

AFAICT not a regression in trunk (0.91preX)

<off-topic>
On 2014-08-19 24:04 , Kevin Yin wrote:
> Inkscape places some of my newly created paths in the root layer,
> but that's not the bug I'm reporting here because I don't understand
> why this behavior occurs.

Two common situations which unexpectedly make 'root' the current layer:
- Bug #505225: if the 'type-ahead find' popup is triggered, the current drawing level is switched to 'root'
- Bug #1086296: 'Live Preview' toggle unsets current layer if nothing is selected

Another occasion:
- Bug #394503: bitmap files get Opened into layer 'root'

As soon as any object in 'root' is selected with the mouse, the current drawing level switches to 'root', and new objects drawn or pasted at this point will also end up in 'root' until the current drawing level is changed again (e.g. by clicking on an object in a regular layer).

Related reports about objects trapped in 'root':
Bug #488561: Object still visible when all layers switched off.
Bug #792175: Root layer should be included in the Layers palette
</off-topic>

Testing agrees with suv's observations. My previous testing was sloppy.

Very old versions worked as expected (no need to click twice).
But things changed revision 892 (see http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/annotate/892/src/dialogs/layers-panel.cpp#L272), I don't understand why - the commit message is not very informative.

The attached patch removes the unselection of the selected objects list. But since I'm not sure the unselection was added purposely (as a fix for another bug maybe), the patch needs to be checked carefully for possible side-effects.

Found one side effect: the last selected layer in the layers dialog is still selected when selecting an object in the root layer.

Ok, I misunderstood the layers dialog code. selection()->unselect_all() doesn't apply to the current document selection, but to the layers dialog tree...