Allow dropper tool to edit current custom swatch fill

Attached patch should work as per proposal above, please test.

Patch looks good to me in initial tests (OS X 10.7.4, GTK+/X11 2.24.13, r11806) - would be great though if it gets tested by other (experienced) users who work with trunk builds on complex drawings, and make use of the 'Auto' palette feature.

Likely this will only get tested by other users once it's committed in current trunk.

not sure whether this goes here, in #239392 or #172236

but in r11729, i cant select the stroke color with the color picker, having the stroke color selection editor and clicking on the color picker makes changes to the fill, not the stroke.

insaner wrote
> not sure whether this goes here, in #239392 or #172236
>
> but in r11729, i cant select the stroke color with the color picker (…)

Unless you are testing the patch from comment #2, it doesn't go here (the proposed patch for the requested feature here in bug #1049481 has not been committed yet).

Note that this report is about changing the color of custom swatches (i.e. named paint servers in the 'Auto' palette) with the dropper tool, not about normal fill or stroke colors.

Not to have to use 'Shift' to affect the stroke color with the dropper tool when called as "one time" pick from Fill&Stroke would be related to bug #172236 (either comment there or file a follow-up report requested this feature). It's troubling though, because either solution is inconsistent in some way (IMHO).

insaner wrote:
> not sure whether this goes here, in #239392 or #172236
>
> but in r11729, i cant select the stroke color with the color picker (…)

Ah, now I realize that the dropper support for custom swatch colors for the 'Stroke paint' is also missing in the patch from comment #2.

@John - based on how the patch works when using the 'one time' dropper tool from the 'Swatch fill' variant of the 'Fill' pane, could you also implement it on the 'Swatch Fill' variant of the 'Stroke paint' pane, so that the 'one time' dropper tool there modifies the custom swatch color in use for the stroke of the current selection?

@John - what do you think about the issue raised by insaner (comment #5) [1], and about the patch you wrote earlier for better swatch support?

[1] could possibly also be the cause for <http://article.gmane.org/gmane.comp.graphics.inkscape.devel/39418> though the user doesn't disclose whether he actually has a development snapshot build installed.

A fix for the problem insaner mentions (comment #5) has been committed (see bug #172236).
This patch should work together with that commit.

One concern, what is the preferred behavior with the dropper when a non-solid (gradient) swatch is selected ?

> what is the preferred behavior with the dropper
> when a non-solid (gradient) swatch is selected ?

Initially I thought this could be addressed by limiting this new feature to the scope of the 'one-time' dropper tool (i.e. when called from the button in the color selector widget in the Fill&Stroke dialog): thus it would either modify the color of the solid swatch, or the stop color of the selected gradient stop (be it a regular gradient or a gradient swatch). The normal mode of the dropper tool would still replace the swatch with a regular flat color (like it does with objects which use a gradient paint server).

Unfortunately the content of the Fill&Stroke panel for gradient swatches is soemwhat inconsistent in this regard (it displays the color selector even though only the first stop of the gradient swatch is actually modifiable), and thus currently doesn't allow above solution.