Style: Don't explicitly cache regexs
Bug #390031 reported by
Stefano Rivera
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ibid |
Fix Committed
|
Low
|
Stefano Rivera | ||
Bug Description
We manually cache regexs all over the place. We probably shouldn't do that, as python caches popular ones for us.
Related branches
lp://staging/~stefanor/ibid/re-caching-390031
- Max Rabkin: Approve
- Michael Gorven: Abstain
- Keegan Carruthers-Smith: Approve
- Jonathan Hitchcock: Approve
-
Diff: 237 lines (+21/-29)10 files modifiedibid/auth.py (+2/-3)
ibid/db/versioned_schema.py (+3/-2)
ibid/lib/dcwords.py (+4/-4)
ibid/plugins/conversions.py (+2/-3)
ibid/plugins/fun.py (+2/-3)
ibid/plugins/geography.py (+1/-2)
ibid/plugins/lotto.py (+3/-5)
ibid/plugins/quotes.py (+2/-3)
ibid/plugins/rfc.py (+1/-2)
ibid/source/smtp.py (+1/-2)
Revision history for this message
| Michael Gorven (mgorven) wrote Re: [Bug 390031] [NEW] Style: Don't explicitly cache regexs | #1 |
| Changed in ibid: | |
| milestone: | 0.1 → 0.2 |
| Changed in ibid: | |
| status: | New → Triaged |
| Changed in ibid: | |
| assignee: | nobody → Stefano Rivera (stefanor) |
| status: | Triaged → In Progress |
| Changed in ibid: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
I tend to prefer compiled regexes from a style POV because you don't have to
interpret the regex every time to work out what it does. I'd like to defer
this to 0.2 in any case, unless someone objects.
milestone 0.2