One Hundred Papercuts

"Open location" dialog should not close on invalid path

Bug #385785 reported by David
34
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Nautilus
Expired
Low
One Hundred Papercuts
Triaged
Low
Unassigned
nautilus (Ubuntu)
Triaged
Wishlist
Ubuntu Desktop Bugs

Bug Description

In nautilus, the "Open location" window (showed with CTRL+L) should stay open when an invalid path is used. This will let the user correct it's mistake and retry faster the corrected path.

upstream bug report : http://bugzilla.gnome.org/show_bug.cgi?id=512171

Bug Watch Updater (bug-watch-updater)
Changed in nautilus:
status: Unknown → New
Revision history for this message
Sebastien Bacher (seb128) wrote :

That's something easy to change, can be targeted for karmic if the design team confirm what is the best option

Changed in nautilus (Ubuntu):
assignee: nobody → Ubuntu Desktop Bugs (desktop-bugs)
importance: Undecided → Wishlist
status: New → Confirmed
David Siegel (djsiegel-deactivatedaccount)
Changed in hundredpapercuts:
status: New → Confirmed
David Siegel (djsiegel-deactivatedaccount)
summary: - Nautilus open location should not close on invalid path
+ "Open location" dialog should not close on invalid path
David Siegel (djsiegel-deactivatedaccount)
Changed in hundredpapercuts:
milestone: none → round-2
David Siegel (djsiegel-deactivatedaccount)
Changed in hundredpapercuts:
milestone: round-2 → round-1
Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

Ideally, we would check for existence before the user clicks "Open", and enable/disable the Open button accordingly.

A second-best solution is to leave the "Open Location" dialog open when the "Could not find <location>" dialog is shown so the user can correct the error.

Changed in hundredpapercuts:
status: Confirmed → Triaged
assignee: nobody → David Siegel (djsiegel)
David Siegel (djsiegel-deactivatedaccount)
Changed in hundredpapercuts:
assignee: David Siegel (djsiegel) → nobody
David Siegel (djsiegel-deactivatedaccount)
Changed in hundredpapercuts:
milestone: round-1 → round-6
Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :

Setting the bug to "triaged" since it has enough information for a developer to work on it.

Changed in nautilus (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

I'm working on this and will probably have an initial patch later this week.

Changed in hundredpapercuts:
assignee: nobody → Marcus Carlson (0-launchpad-mejlamej-nu)
Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

If you're running karmic you could try this out from my PPA [1].
Changes;
 - Makes the open location a little bit smarter and does not allow you to open a local path that doesn't exists and shows this by disabling the Open button and adding the text "Location does not exist" under the entry.
 - Opening a remote folder that cannot open now results in that the location dialog gets back to the user with the same path entered from start (as this bug describes)

Comments are welcome, will talk to upstream in the coming days.

[1] https://launchpad.net/~0-launchpad-mejlamej-nu/+archive/ppa

Revision history for this message
A. Walton (awalton) wrote :

Patch does blocking I/O (g_file_query_exists()), which is strictly prohibited in Nautilus.

Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

A. Walton, thanks for reviewing the patch!
How do I solve this? Will g_file_query_info_async () do the trick?

Revision history for this message
A. Walton (awalton) wrote :

Ideally you'd want to use the NautilusFile machinery, since there's a better-than-good chance that the location being entered has already been cached, but NautilusFile isn't exactly the best way to tell if a file /isn't/ there, so you're almost forced to having to roll your own lookup stuff there (with query_async() and friends).

I'm not particularly in favor of this as it adds a whole lot of complexity to something that's pretty simple as it is, and potentially causes some really odd interface bugs, but I guess I shouldn't complain too loudly if I'm not doing the ground work on this ;).

Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

A. Walton, I'm not sure I'm the right person for all the async stuff.

But if we look at the other part of the patch, the one that brings the open location dialog back after unsuccessfully opening a location. Does that look good enough to send upstream?

Revision history for this message
Alejandro Vidal (mancvso) wrote :

@Marcus: i really think this is enough... why make this complex?

Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

dael99, work is progressing upstream - I now focus on getting the Open Location dialog back after failure to open the location. The first patch was not accepted by upstream because it was using blocking I/O.

David Siegel (djsiegel-deactivatedaccount)
Changed in hundredpapercuts:
milestone: round-6 → lucid-round-3
Revision history for this message
Vish (vish) wrote :

Marcus , any idea why the upstream bug has stalled?

Changed in hundredpapercuts:
importance: Undecided → Low
Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

I'm waiting for someone (eg Alex) to review the patch. I could ping him on Monday again.

Vish (vish)
Changed in hundredpapercuts:
milestone: lucid-round-3 → none
milestone: none → maverick-round-1-file-management
Vish (vish)
Changed in hundredpapercuts:
status: Triaged → In Progress
Bug Watch Updater (bug-watch-updater)
Changed in nautilus:
importance: Unknown → Low
Vish (vish)
Changed in hundredpapercuts:
milestone: maverick-round-1-file-management → nt4-nautilus
Revision history for this message
Timothy Arceri (t-fridey) wrote :

No progress in a year changing back to confirmed

Changed in hundredpapercuts:
status: In Progress → Confirmed
Timothy Arceri (t-fridey)
Changed in hundredpapercuts:
assignee: Marcus Carlson (0-launchpad-mejlamej-nu) → Timothy Arceri (t-fridey)
milestone: nt4-nautilus → precise-1-file-management
Timothy Arceri (t-fridey)
Changed in hundredpapercuts:
status: Confirmed → In Progress
Chris Wilson (notgary-deactivatedaccount)
Changed in hundredpapercuts:
milestone: precise-1-file-management → quantal-6-file-management
Revision history for this message
Chris Wilson (notgary-deactivatedaccount) wrote :

What's the progress on this fix?

Revision history for this message
Timothy Arceri (t-fridey) wrote :

I no long have time to work on ubuntu. Also someone might need to check if this option is still in the new nautilus I thought I read somewhere this was something that got removed from the latest version.

Changed in hundredpapercuts:
status: In Progress → Triaged
assignee: Timothy Arceri (t-fridey) → nobody
Chris Wilson (notgary-deactivatedaccount)
Changed in hundredpapercuts:
milestone: quantal-6-file-management → papercuts-nautilus
Chris Wilson (notgary-deactivatedaccount)
Changed in hundredpapercuts:
milestone: papercuts-nautilus → papercuts-s-nautilus
Bug Watch Updater (bug-watch-updater)
Changed in nautilus:
status: New → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.