Ambiance & Radiance themes are missing a "background-color" for tooltip elements (needed for GTK3-enabled Firefox Nightly)

Steps to reproduce (sorry for not including these up-front):

 1. Download a "Desktop" firefox nightly build from https://nightly.mozilla.org/

 2. Extract the tarball, e.g.:
  tar jxvf firefox-42.0a1.en-US.linux-x86_64.tar.bz2

3. From inside the extracted directory, create an empty folder and start Firefox Nightly using that folder as your profile:
   cd firefox
   mkdir /tmp/ffprof; ./firefox -profile /tmp/ffprof -no-remote

 4. (Tell the pop-up dialog no, don't make this your default browser.)

 5. Look at the dropdown notification bar at the top of the browser.

ACTUAL RESULTS: ~white text on ~white background, as shown in screenshot here:
https://bug1187203.bmoattachments.org/attachment.cgi?id=8638351

Note that *actual tooltips* are fine, since they render with the background-image, as specified in gtk-widget.css.

But firefox's notification bars have trouble because they don't get rendered with the full GTK styling. Firefox sets up a dummy widget and styles it as a tooltip, and reads its "background-color" and "color" styling, and assumes that those will be useful. And the problem is that background-color does not currently have a useful value (in that it's basically the same as the foreground color), because these GTK themes reasonably don't expect that they need to provide a background-color, since they're providing a background-image instead.

Here's a patch to fix this. (generated against source obtained from "apt-get source ubuntu-themes").

I'm hoping someone here can take this & land it. Please let me know if there's anything else that's needed here. Thanks!

FWIW, I verified that this patch fixes the Firefox issue if I apply it directly to my system, like so:
  cd /usr/share/themes/
  sudo patch -p1 < /tmp/theme-patch.patch

The attachment "patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

I have not had a change to test this on older Ubuntus with the new nightly firefox yet but I can confirm this is a issue with 15.04 & 15.10 . And since when this hits in the latest firefox (that will be shipped on nearly all supported Ubuntu builds) this fix may need to be tested and applied to older and newer builds of Ambaince Themes (EG one in 14.04 , 12.04 etc.) I am not sure yet however.

FWIW, Firefox actually worked around this bug locally by making the bits of firefox-UI in question able to paint the Theme's background gradient (and we're making sure that any future release with GTK3 enabled will include this patch). It may still be worth taking the theme patch that I attached here, but I don't think it'll affect Firefox's behavior anymore.

So, I think this is WORKSFORME. Not sure what the correct launchpad resolution is for that, but I'll let Launchpad folks close out this bug as-appropriate.

I have created the following merge proposal to address this issue:

  * https://code.launchpad.net/~flexiondotorg/ubuntu-themes/lp1478173/+merge/308124

I disagree with closing this as “WORKSFORME”. Just because core Firefox plastered over the problem does not mean it's not an issue for other cases. I have at least one Firefox add-on that continues to display unreadable text because this bug causes the CSS InfoBackground and InfoText values in styles to result in white-on-white text colors. It will even affect websites that happen to style themselves in these colors (example demo: https://artific.com/library/css-2-system-colors.html). Who knows what other software might also be affected. I have just tried the patch posted here and can confirm that the issues I describe are definitely caused by this bug.

The themes are clearly broken and should be fixed. An explicit background *and* foreground color should always be specified. There is no guarantee the background image/effect will be used by a given application, and relying on it is only asking for random usability problems.

Same issue here in Trusty with Jamulus tooltips : https://github.com/corrados/jamulus/issues/456