Creating Mask crash fix

Bug #2028087 reported by p.w.wong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Hugin
Fix Released
Undecided
Unassigned

Bug Description

(using a my build of hugin-2022.0.0 on MacOS v10.12.6) When creating a mask for exclude region, hugin would sometimes crash. This attach patch fixes this issue.

Revision history for this message
p.w.wong (phil-weballey) wrote :
Revision history for this message
tmodes (tmodes) wrote :

Adding twice a comment with your initials and a date is not helpful. This can be tracked with mercurial.
More helpful would be a comment with a description why the separate code block is necessary.

And why does it only happens with exclude region? Should be the same happen also with include region?

Changed in hugin:
status: New → Incomplete
Revision history for this message
p.w.wong (phil-weballey) wrote : Re: [Bug 2028087] Re: Creating Mask crash fix

On 7/25/23 1:42 PM, tmodes wrote:
> Adding twice a comment with your initials and a date is not helpful. This can be tracked with mercurial.
> More helpful would be a comment with a description why the separate code block is necessary.
>
> And why does it only happens with exclude region? Should be the same
> happen also with include region?
>
> ** Changed in: hugin
> Status: New => Incomplete
>

Sorry about the comment... it was for my internal use and I forget to
remove.

As for the separate code block, from stepping through with the debugger,
there appears to be a race condition that appears to resolved by
serializing in this fashion. If I recall correctly, I was getting a
fault in the m_overlay.Reset() before the overlaydc.Clear() completed.

-phil
--
"Pretending that the all-but-inevitable is inconceivable doesn't
make it impossible."

Phillip W. Wong, PE (<email address hidden>)

Revision history for this message
tmodes (tmodes) wrote :

Ok, committed to repository with a comment about it.

Changed in hugin:
milestone: none → 2023.0beta1
status: Incomplete → Fix Committed
tmodes (tmodes)
Changed in hugin:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.