Leaks in QtGActionGroup
Bug #1296746 reported by
Pete Woods
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity HUD |
Fix Released
|
High
|
Charles Kerr | ||
hud (Ubuntu) |
Fix Released
|
High
|
Charles Kerr |
Bug Description
There are a few leaks in QtGActionGroup
Related branches
lp://staging/~charlesk/hud/qtgactiongroup-cleanup
- Marcus Tomlinson (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 147 lines (+16/-43)3 files modifiedlibqtgmenu/internal/QtGActionGroup.cpp (+14/-39)
libqtgmenu/internal/QtGActionGroup.h (+0/-4)
libqtgmenu/internal/QtGMenuUtils.cpp (+2/-0)
Changed in hud: | |
assignee: | nobody → Charles Kerr (charlesk) |
status: | New → In Progress |
importance: | Undecided → High |
Changed in hud (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Charles Kerr (charlesk) |
Changed in hud: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package hud - 13.10.1+ 14.04.20140326- 0ubuntu1
--------------- 1+14.04. 20140326- 0ubuntu1) trusty; urgency=low
hud (13.10.
[ Pete Woods ]
* Add safety valve for DBusMenuCollector that also reports the
offending application (LP: #1280372)
hud (13.10. 1+14.04. 20140325- 0ubuntu1) trusty; urgency=low
[ Charles Kerr ] group_list_ actions( ) :Action( ), but then I found oup::Action( ) was only called in the object's constructor oup::TriggerAct ion() * Plugged char* leak in s::makeStringLi stQVariant * ActionGroup ctor calls group_list_ actions( ) once instead of n+1 times * group_list_ actions( ) once instead of
* Simplify the implementation of QtGActionGroup. This started off with
the intent of removing the overhead of g_action_
in QtGActionGroup:
QtGActionGr
and destructor, so it made more sense to remove the function
altogether. Summary of changes: * Plugged GVariant leak in
QtGActionGr
QtGMenuUtil
g_action_
ActionGroup dtor calls g_action_
n times * Removed unused public method Size() * Removed newly-
unused public method Action() * Removed newly-unused field m_size
(LP: #1296746)
[ Pete Woods ] pubs.opengroup. org/onlinepubs/ 000095399/ functions/ xsh_chap02_ html#tag_ 02_04_01 (LP: #1296602)
* Add null guards to ItemStore search (LP: #1292237)
* Fix test failures exposed by fix to libqtdbustest (LP: #1296744)
* Call only "safe" write method from UNIX signal handler See
http://
04.
-- Ubuntu daily release <email address hidden> Wed, 26 Mar 2014 09:36:22 +0000