Actually not THAT useful. I meant to follow up on this to say: "Nope, I'm mostly wrong."
* It's true that identity comparisons between variables and literals are ill-advised.
* It's true that they cause a SyntaxWarning to be emitted. (...WTF is a "syntax WARNING"?!?)
* However, they still WORK in Python, because... *sigh* because they just do.
So, while it's (IMHO) worth fixing these, it's not nearly as urgent/imperative as I made it sound.
(Except for the pexpect order-of-operations one, that's genuinely a bug.)
Heh! Thanks, Colin.
Actually not THAT useful. I meant to follow up on this to say: "Nope, I'm mostly wrong."
* It's true that identity comparisons between variables and literals are ill-advised.
* It's true that they cause a SyntaxWarning to be emitted. (...WTF is a "syntax WARNING"?!?)
* However, they still WORK in Python, because... *sigh* because they just do.
So, while it's (IMHO) worth fixing these, it's not nearly as urgent/imperative as I made it sound.
(Except for the pexpect order-of-operations one, that's genuinely a bug.)