HPLIP

Wrong capitalization in wifi setup dialog

Bug #1795875 reported by Manfred Hampl
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HPLIP
Fix Committed
Undecided
Unassigned

Bug Description

From hplip 3.18.9 hplip/ui5/wifisetupdialog.py

        beginWaitCursor()
...
                self.ip,_,addressmode, subnetmask, gateway, pridns,\
                        sec_dns=\
self.wifiObj.getIPConfiguration(self.dev, self.adapterName)
                if self.ip == "0.0.0.0":
                    self.ip, subnetmask, gateway, pri_dns, sec_dns,\
                        addressmode =\
self.wifiobj.getwifiotherdetails(self.dev,self.adapterName)
...

Why is wifiobj in "self.wifiobj.getwifiotherdetails" (in the "if ip=0.0.0.0" branch, line 573) written with a small o instead of a capital O?

This was reported by Erik P. Olsen in https://answers.launchpad.net/hplip/+question/674342 but his question was shrugged off.

See original description
Manfred Hampl (m-hampl)
description: updated
Revision history for this message
srinivas (srinivas5) wrote :

Hi,
We checked the wifisetupdialog.py file and it is "wifiObj.getwifiotherdetails" only. Please try on latest HPLIP driver 3.18.9.
We have verified wifi option with hp printers in 3.18.9 and it worked fine.

Thanks,
Srinivas Teja

Changed in hplip:
status: New → In Progress
Revision history for this message
Manfred Hampl (m-hampl) wrote :

Please compare line 566 in hplip/ui4/wifisetupdialog.py and line 573 in hplip/ui5/wifisetupdialog.py

The problem that I try to make you aware of is only in ui5/wifisetupdialog.py
Capitalization in ui4/wifisetupdialog.py seems to be correct.

Revision history for this message
Erik P. Olsen (erik-epo) wrote :

Tried to run hpli 3.18.9 and got:
[erik@Erik-PC Hplip]$ ./hplip-3.18.9.run
Creating directory hplip-3.18.9
Verifying archive integrity...Error in MD5 checksums: fc13708a58081673b8cfba6c573c9ad0 is different from 67be478c26ce5190f806f498b41204f3

Regards, Erik.

Revision history for this message
Manfred Hampl (m-hampl) wrote :

@Erik P. Olsen:
The message that you see has nothing to do with the problem that is covered by this bug message.
You should try re-downloading the hplip-3.18.9.run file.

Revision history for this message
Manfred Hampl (m-hampl) wrote :

The error with wrong capitalization (wifiobj instead of wifiObj) in ui5/wifisetupdialog.py line 573 is still there in HPLIP 3.18.12.

Revision history for this message
Manfred Hampl (m-hampl) wrote :

The error with wrong capitalization (wifiobj instead of wifiObj) in ui5/wifisetupdialog.py line 573 is still there in HPLIP 3.19.3.

Revision history for this message
Umesh Mahindrakar (umesh.mahindrakar) wrote :

Hi Manfred,

Thanks for finding out the error. We will incorporate changes. You can see the changes in the next build.

Thanks,
Umesh

Umesh Mahindrakar (umesh.mahindrakar)
Changed in hplip:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.