HPLIP

scan.py - scans cannot be saved as JPEG since python-pillow-4.2.0

Bug #1741214 reported by zdohnal on 2018-01-04

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	HPLIP	In Progress	Undecided	Unassigned

Bug Description

Hi,

python-pillow released new version (4.2.0), which forbids saving RGBA data to JPEG. This behavior breaks scanning by hp-scan. Output is:

$ hp-scan -m color -s file
Saving to file /home/zdohnal/hpscan001.jpg
error: Error saving file: cannot write mode RGBA as JPEG (I/O)

These RGBA data needs to be convert to RGB data before saving as JPEG (other formats - PNG, PNM, TIFF etc. - works fine, because they doesn't ignore A channel). The attached patch fixes it.

Tags:

Revision history for this message

zdohnal (zdohnal) wrote on 2018-01-04:

Patch Edit (533 bytes, text/plain)

Revision history for this message

meeuw (dick-mrns) wrote on 2018-01-07:

Thanks for the patch, I think you should remove the if 'JPEG' condition, it's also required for raw scans.

Revision history for this message

zdohnal (zdohnal) wrote on 2018-01-08:

hplip-jpeg-compression.patch Edit (622 bytes, text/plain)

Ah, I overlooked raw option! Sorry, you're right of course.

Revision history for this message

Nishitha Antony (ni301701) wrote on 2018-01-11:

Hi,
We tried to reproduce the reported issue in lab and it is reproducible. We will discuss this with HP program management team for incorporating this fix in the next release and keep you posted on the updates.
Thanks,
Nishitha