When adding ICMP rule, the type/code is being validated as from/to ports

Fix proposed to branch: master
Review: https://review.openstack.org/8446

Reviewed: https://review.openstack.org/8446
Committed: http://github.com/openstack/horizon/commit/7b565fc9839833b4b99b1fc3b02269b79071af3e
Submitter: Jenkins
Branch: master

commit 7b565fc9839833b4b99b1fc3b02269b79071af3e
Author: Tihomir Trifonov <email address hidden>
Date: Tue Jun 12 17:50:18 2012 +0300

    Fixed validation check for ICMP rules

    Fixed the code that checks the ICMP type/code
    as from/to ports. Also fixed the CSS for the
    security rules form, and the script to change
    the form labels in case of form reload due to
    an error.

    Fixes bug 997669

    Change-Id: I3b9c0ba3f46b91a311f887560dae5e9399961b84

Would it be backported to stable/essex?

Fix proposed to branch: stable/essex
Review: https://review.openstack.org/10078

Reviewed: https://review.openstack.org/10078
Committed: http://github.com/openstack/horizon/commit/9b22d68f3d49f58a36391c38d502e6cadd051bd6
Submitter: Jenkins
Branch: stable/essex

commit 9b22d68f3d49f58a36391c38d502e6cadd051bd6
Author: Tihomir Trifonov <email address hidden>
Date: Tue Jun 12 17:50:18 2012 +0300

    Fixed validation check for ICMP rules

    Fixed the code that checks the ICMP type/code
    as from/to ports. Also fixed the CSS for the
    security rules form, and the script to change
    the form labels in case of form reload due to
    an error.

    Fixes bug 997669

    Change-Id: I3b9c0ba3f46b91a311f887560dae5e9399961b84
    (cherry picked from commit 7b565fc9839833b4b99b1fc3b02269b79071af3e)

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

This bug was fixed in the package horizon - 2012.1.3+stable~20120815-691dd2-0ubuntu1

---------------
horizon (2012.1.3+stable~20120815-691dd2-0ubuntu1) precise-proposed; urgency=low

  [ Chuck Short ]
  * New upstream release (LP: #1041120):
    - 9b22d6 - Fixed validation check for ICMP rules. (LP: #997669)
  * Dropped:
    - debian/patches/CVE-2012-2094.patch: No longer needed.
    - debian/patches/CVE-2012-2144.patch: No longer needed.

   [ Adam Gandelman ]
   * debian/patches/juju_panel-handle_catalog_exception.patch: Gracefully handle
    missing endpoints in Keystone catalog during Juju environmnets.yaml
    generation. (LP: #1033920)
 -- Adam Gandelman <email address hidden> Tue, 24 Aug 2012 03:27:33 -0500

Hello Tihomir, or anyone else affected,

Accepted horizon into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/horizon/2012.1.3+stable-20130423-5ce39422-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Please find the attached test log from the Ubuntu Server Team's CI infrastructure. As part of the verification process for this bug, Horizon has been deployed and configured across multiple nodes using precise-proposed as an installation source. After successful bring-up and configuration of the cluster, a number of exercises and smoke tests have be invoked to ensure the updated package did not introduce any regressions. A number of test iterations were carried out to catch any possible transient errors.

Please Note the list of installed packages at the top and bottom of the report.

For records of upstream test coverage of this update, please see the Jenkins links in the comments of the relevant upstream code-review(s):

Trunk review: https://review.openstack.org/8446
Stable review: https://review.openstack.org/10078

As per the provisional Micro Release Exception granted to this package by the Technical Board, we hope this contributes toward verification of this update.

Test coverage log.