OpenStack Dashboard (Horizon)

New security group rule - flaky validation

Bug #1867505 reported by Radosław Piliszek on 2020-03-15

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Triaged	Medium	Unassigned

Bug Description

OS release: Train

When adding new custom IP protocol rule, the IP protocol is neither required nor has any default.
Submission without filling this field in results in "Form submission failed" error w/o any other decent error message.
I suggest making this field required (as it really is).

Revision history for this message

Vishal Manchanda (vishalmanchanda) wrote on 2020-03-25:

Capture.PNG Edit (65.0 KiB, image/png)

Hi Radosław Piliszek, Could you elaborate you are referring to which field exactly. As you can see in the attachment all of the filed while adding a new Ip protocol rule is already required fields.

Revision history for this message

Radosław Piliszek (yoctozepto) wrote on 2020-03-25:

"Custom *IP* Rule", not TCP

Revision history for this message

Vishal Manchanda (vishalmanchanda) wrote on 2020-03-25:

To make 'ip_protocol' field mandatory-you just need to add 'data-required-when-shown': 'true' at [1].

[1] https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/security_groups/forms.py#L135