OpenStack Dashboard (Horizon)

Preview Page: Modal location is off

Bug #1581669 reported by Diana Whitten on 2016-05-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Medium	Diana Whitten	OpenStack Dashboard (Horizon) newton-1 "n1"

Bug Description

There is JavaScript in horizon that is forcing a hardcoded top offset for the modal. This is causing shenanigans on the theme preview page for the lower sections.

Tags:

Revision history for this message

Diana Whitten (hurgleburgler) wrote on 2016-05-13:

Screen Shot 2016-05-13 at 1.28.22 PM.png Edit (200.7 KiB, image/png)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-13: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/316279

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-17: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/316279
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=16895968a9be63d457de19566d5bffd20befe867
Submitter: Jenkins
Branch: master

commit 16895968a9be63d457de19566d5bffd20befe867
Author: Diana Whitten <email address hidden>
Date: Fri May 13 13:30:00 2016 -0700

Preview Page: Modal location is off

    There is JavaScript in horizon that is forcing a hardcoded inline
    style for the top offset of the modal. This is causing shenanigans
    on the theme preview page for the lower sections.

    There existed a hardcoded CSS class in _debt.scss that was undoing
    this JavaScript hardcode, but neither is needed. Bootstrap should
    work properly by itself.

Closes-bug: #1581669

Change-Id: I3bab355be0c53fdd3c6ba8c91846c6c54ebcee4d