Bug #1561612 “Can't edit users “Unable to update the user"" : Bugs : OpenStack Dashboard (Horizon)

Doug Fish (drfish) on 2016-03-24

Changed in horizon:
importance:	Undecided → Critical

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-03-24

tags:	added: mitaka-backport-potential
Changed in horizon:
status:	New → Confirmed
milestone:	none → newton-1

David Lyle (david-lyle) on 2016-03-24

Changed in horizon:
assignee:	nobody → David Lyle (david-lyle)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-03-24: Fix proposed to horizon (master)

#1

Fix proposed to branch: master
Review: https://review.openstack.org/297300

Changed in horizon:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-03-24: Fix proposed to horizon (stable/mitaka)

#2

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/297326

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-03-25: Change abandoned on horizon (stable/mitaka)

#3

Change abandoned by David Lyle (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/297326
Reason: parent changed

Revision history for this message

David Lyle (david-lyle) wrote on 2016-03-28:

#4

The last patch is restored, but blocked until the fix merges on master.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-03-29: Fix merged to horizon (master)

#5

Reviewed: https://review.openstack.org/297300
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=32510d8211a43d83ebac6478fce17a8856cf9a0c
Submitter: Jenkins
Branch: master

commit 32510d8211a43d83ebac6478fce17a8856cf9a0c
Author: David Lyle <email address hidden>
Date: Thu Mar 24 12:22:29 2016 -0600

Fixing updating user with no default project

    The selector for setting the default project passes on an empty string
    if the value is not changed. This is causing an error from keystone as
    an empty string is not a valid project ID.

To fix, a couple of things have been done:

    First, as user_update is a PATCH, we no longer pass on the default
    project as a parameter in the update when using keystone v3
    and the value did not change when editing the user.

    Second, there is currently no way to unset the default project
    using keystoneclient. An entry in the default project select
    "select a project" has been removed when the default project is
    already set. The entry was selectable and resulted in the
    problematic empty string. The current default project is already
    selected at load time. The ability to select a different default
    project is maintained.

Additionally, keystone v2.0 functionality is not effected, as the
default project id is required in v2.0.

A test was added to cover the case of editing the default project.

Closes-Bug: #1561612
Change-Id: I3c84ee5c7af846b5a58f2dd0342a537d312323cf

Changed in horizon:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-03-31: Fix merged to horizon (stable/mitaka)

#6

Reviewed: https://review.openstack.org/297326
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=10e6bf57c3398c73ec47dabd91fbd37f35017abc
Submitter: Jenkins
Branch: stable/mitaka

commit 10e6bf57c3398c73ec47dabd91fbd37f35017abc
Author: David Lyle <email address hidden>
Date: Thu Mar 24 12:22:29 2016 -0600

Fixing updating user with no default project

    The selector for setting the default project passes on an empty string
    if the value is not changed. This is causing an error from keystone as
    an empty string is not a valid project ID.

To fix, a couple of things have been done:

    First, as user_update is a PATCH, we no longer pass on the default
    project as a parameter in the update when using keystone v3
    and the value did not change when editing the user.

    Second, there is currently no way to unset the default project
    using keystoneclient. An entry in the default project select
    "select a project" has been removed when the default project is
    already set. The entry was selectable and resulted in the
    problematic empty string. The current default project is already
    selected at load time. The ability to select a different default
    project is maintained.

Additionally, keystone v2.0 functionality is not effected, as the
default project id is required in v2.0.

A test was added to cover the case of editing the default project.

    Closes-Bug: #1561612
    Change-Id: I3c84ee5c7af846b5a58f2dd0342a537d312323cf
    (cherry picked from commit 32510d8211a43d83ebac6478fce17a8856cf9a0c)

tags:

added: in-stable-mitaka

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-03-31: Fix included in openstack/horizon 9.0.0.0rc2

#7

This issue was fixed in the openstack/horizon 9.0.0.0rc2 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-07: Fix proposed to horizon (master)

#8

Fix proposed to branch: master
Review: https://review.openstack.org/302566

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-07: Fix merged to horizon (master)

#9

Download full text (5.6 KiB)

Reviewed: https://review.openstack.org/302566
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=070da819f9d88d4c9736dfe5d49b56756be0cfe5
Submitter: Jenkins
Branch: master

commit 3f4eeaa6c0fea01ca7820b85a754c931c2a4da0e
Author: OpenStack Proposal Bot <email address hidden>
Date: Thu Mar 31 06:51:12 2016 +0000

Imported Translations from Zanata

For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Ia0b04ca1b44d72796ff2b60e47a9664e5473dc44

commit 10e6bf57c3398c73ec47dabd91fbd37f35017abc
Author: David Lyle <email address hidden>
Date: Thu Mar 24 12:22:29 2016 -0600

Fixing updating user with no default project

    The selector for setting the default project passes on an empty string
    if the value is not changed. This is causing an error from keystone as
    an empty string is not a valid project ID.

To fix, a couple of things have been done:

    First, as user_update is a PATCH, we no longer pass on the default
    project as a parameter in the update when using keystone v3
    and the value did not change when editing the user.

    Second, there is currently no way to unset the default project
    using keystoneclient. An entry in the default project select
    "select a project" has been removed when the default project is
    already set. The entry was selectable and resulted in the
    problematic empty string. The current default project is already
    selected at load time. The ability to select a different default
    project is maintained.

Additionally, keystone v2.0 functionality is not effected, as the
default project id is required in v2.0.

A test was added to cover the case of editing the default project.

    Closes-Bug: #1561612
    Change-Id: I3c84ee5c7af846b5a58f2dd0342a537d312323cf
    (cherry picked from commit 32510d8211a43d83ebac6478fce17a8856cf9a0c)

commit dd4d1fb79defb65fc54c8239792a211e661433b4
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Mar 30 06:53:15 2016 +0000

Imported Translations from Zanata

For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Icd8f62341a7144425149034e338956212bdab408

commit 19b6a657ef41c35fd7cfac32801d8362f82116ea
Author: Timur Sufiev <email address hidden>
Date: Thu Mar 24 16:21:21 2016 +0300

Fix opening multiple Launch Instance during jQuery table polling

Achieve this by limiting widget area to be recompiled to table/tab.

    Change-Id: Icbbe2be833fccf17ba272ca920960393c9c3b667
    Closes-Bug: #1561501
    Closes-Bug: #1559105

commit 8ad7d1fb01a75716861bad7b8ee3ce930f42724d
Author: OpenStack Proposal Bot <email address hidden>
Date: Tue Mar 29 06:29:37 2016 +0000

Imported Translations from Zanata

For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Ifd623cc19478ec044c5fbab9ced4a37dfa490553

commit 2694d45ac69c6884433c15f8294d43db1...

Reviewed:  https://review.openstack.org/302566
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=070da819f9d88d4c9736dfe5d49b56756be0cfe5
Submitter: Jenkins
Branch:    master

commit 3f4eeaa6c0fea01ca7820b85a754c931c2a4da0e
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Thu Mar 31 06:51:12 2016 +0000

Imported Translations from Zanata
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: Ia0b04ca1b44d72796ff2b60e47a9664e5473dc44

commit 10e6bf57c3398c73ec47dabd91fbd37f35017abc
Author: David Lyle <david.lyle@intel.com>
Date:   Thu Mar 24 12:22:29 2016 -0600

Fixing updating user with no default project
    
    The selector for setting the default project passes on an empty string
    if the value is not changed. This is causing an error from keystone as
    an empty string is not a valid project ID.
    
    To fix, a couple of things have been done:
    
    First, as user_update is a PATCH, we no longer pass on the default
    project as a parameter in the update when using keystone v3
    and the value did not change when editing the user.
    
    Second, there is currently no way to unset the default project
    using keystoneclient. An entry in the default project select
    "select a project" has been removed when the default project is
    already set. The entry was selectable and resulted in the
    problematic empty string. The current default project is already
    selected at load time. The ability to select a different default
    project is maintained.
    
    Additionally, keystone v2.0 functionality is not effected, as the
    default project id is required in v2.0.
    
    A test was added to cover the case of editing the default project.
    
    Closes-Bug: #1561612
    Change-Id: I3c84ee5c7af846b5a58f2dd0342a537d312323cf
    (cherry picked from commit 32510d8211a43d83ebac6478fce17a8856cf9a0c)

commit dd4d1fb79defb65fc54c8239792a211e661433b4
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Wed Mar 30 06:53:15 2016 +0000

Imported Translations from Zanata
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: Icd8f62341a7144425149034e338956212bdab408

commit 19b6a657ef41c35fd7cfac32801d8362f82116ea
Author: Timur Sufiev <tsufiev@mirantis.com>
Date:   Thu Mar 24 16:21:21 2016 +0300

Fix opening multiple Launch Instance during jQuery table polling
    
    Achieve this by limiting widget area to be recompiled to table/tab.
    
    Change-Id: Icbbe2be833fccf17ba272ca920960393c9c3b667
    Closes-Bug: #1561501
    Closes-Bug: #1559105

commit 8ad7d1fb01a75716861bad7b8ee3ce930f42724d
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Tue Mar 29 06:29:37 2016 +0000

Imported Translations from Zanata
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: Ifd623cc19478ec044c5fbab9ced4a37dfa490553

commit 2694d45ac69c6884433c15f8294d43db187a9b03
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Mon Mar 28 06:25:33 2016 +0000

Imported Translations from Zanata
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: I96ce6f7270567613351fdde6a092e07ac74e91b9

commit 2143bb60e9a84052ebd54a43b3dfb740b95f338a
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Fri Mar 25 06:25:30 2016 +0000

Imported Translations from Zanata
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: I1f6b5e3f88e75d5af0e8d818884a22d960d555d3

commit 7f1a8316faac5b6df1b7adbe14e16114c23c8212
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Thu Mar 24 06:22:47 2016 +0000

Imported Translations from Zanata
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: I7416224632d54ecf38e71ac6eebbe990449de551

commit 184b67d33d30066781b3345941aa5f6a885a00d5
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Wed Mar 23 06:20:39 2016 +0000

Imported Translations from Zanata
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: I5139fd2bb2976fcbff09be5c494b48d5713f9cc2

commit f1036b4009a820ea3409a8f5280f7681fb23090d
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Tue Mar 22 06:21:19 2016 +0000

Imported Translations from Zanata
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: I646e8f4948f79c1854748843b38b039378a6d5f9

commit 7c71e21909b8bb15c4d49f54712526366fcdac99
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Mon Mar 21 06:21:06 2016 +0000

Imported Translations from Zanata
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: Ib9ad228a065a92edac3b4bc99cd7840fa5da4c0a

commit 5d0391f0faa888b28fefd286b1a6095f46434a2b
Author: Doug Hellmann <doug@doughellmann.com>
Date:   Fri Mar 18 13:51:36 2016 -0400

Update .gitreview for stable/mitaka
    
    Change-Id: Ifeeabb85fdd0994b286d4034774d0a839321760e

Revision history for this message

Davanum Srinivas (DIMS) (dims-v) wrote on 2016-06-02: Fix included in openstack/horizon 10.0.0.0b1

#10

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

OpenStack Dashboard (Horizon)

Can't edit users "Unable to update the user"

Bug Description

Other bug subscribers

Remote bug watches