history-service

Event timestamps should be saved using UTC

Bug #1379018 reported by Gustavo Pichorim Boiko
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
history-service
Fix Released
High
Gustavo Pichorim Boiko
history-service (Ubuntu)
Fix Released
High
Gustavo Pichorim Boiko
history-service (Ubuntu RTM)
Fix Released
Undecided
Unassigned

Bug Description

Currently the history-service is saving events using local time, which is bad as the user might change the timezone and this would mess up with the message order.

UTC should be used instead.

Related branches

lp://staging/~boiko/history-service/save_timestamps_utc
Bill Filler (community): Approve
Diff: 296 lines (+119/-14)
6 files modified
plugins/sqlite/schema/v10.sql (+1/-0)
plugins/sqlite/sqlitedatabase.cpp (+89/-1)
plugins/sqlite/sqlitedatabase.h (+3/-0)
plugins/sqlite/sqlitehistoryplugin.cpp (+12/-7)
plugins/sqlite/sqlitehistoryplugin.h (+2/-0)
plugins/sqlite/tests/SqlitePluginTest.cpp (+12/-6)
PS Jenkins bot: Approve (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 296 lines (+119/-14)
6 files modified
plugins/sqlite/schema/v10.sql (+1/-0)
plugins/sqlite/sqlitedatabase.cpp (+89/-1)
plugins/sqlite/sqlitedatabase.h (+3/-0)
plugins/sqlite/sqlitehistoryplugin.cpp (+12/-7)
plugins/sqlite/sqlitehistoryplugin.h (+2/-0)
plugins/sqlite/tests/SqlitePluginTest.cpp (+12/-6)
lp://staging/ubuntu/vivid/history-service
Gustavo Pichorim Boiko (boiko)
Changed in history-service:
assignee: nobody → Gustavo Pichorim Boiko (boiko)
Bill Filler (bfiller)
tags: added: rtm14
Changed in history-service:
importance: Undecided → Critical
tags: added: touch-2014-10-23
Bill Filler (bfiller)
Changed in history-service (Ubuntu):
assignee: nobody → Gustavo Pichorim Boiko (boiko)
importance: Undecided → Critical
Victor Tuson Palau (vtuson)
Changed in history-service (Ubuntu):
importance: Critical → High
Revision history for this message
Joe Odukoya (jodukoya) wrote :

Undesirable but not considered critical.

Gustavo Pichorim Boiko (boiko)
Changed in history-service:
status: New → In Progress
Changed in history-service (Ubuntu):
status: New → In Progress
Bill Filler (bfiller)
Changed in history-service:
importance: Critical → High
Olli Ries (ories)
tags: added: ota-1
removed: touch-2014-10-23
Pat McGowan (pat-mcgowan)
tags: added: tocuh-2014-10-30
removed: ota-1
tags: added: touch-2014-10-30
removed: tocuh-2014-10-30
Revision history for this message
Olli Ries (ories) wrote :

summary of the last 2 changes: good to go for RTM with proper testing

Revision history for this message
Omer Akram (om26er) wrote :

I have tested the silo and it works as expected. A little niggle is that if you change the timezone while the dialer is already running and make a call afterwards, the time stamp gets permanently saved to the old time. Now even if you restart the app, the time stamp for that call log entry will stay at the old time.

If we are fine with that I can approve the silo.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Omer: that is fine for now. We tried to fix the bug in the least intrusive possible way. We plan to do some improvements on this regard post-RTM.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package history-service - 0.1+14.10.20141103~rtm-0ubuntu1

---------------
history-service (0.1+14.10.20141103~rtm-0ubuntu1) 14.09; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Gustavo Pichorim Boiko ]
  * Save timestamps in UTC. (LP: #1379018)
 -- Ubuntu daily release <email address hidden> Mon, 03 Nov 2014 19:31:23 +0000

Changed in history-service (Ubuntu RTM):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package history-service - 0.1+15.04.20141110-0ubuntu1

---------------
history-service (0.1+15.04.20141110-0ubuntu1) vivid; urgency=low

  [ Gustavo Pichorim Boiko ]
  * Save timestamps in UTC. (LP: #1379018)
  * Remove the tools and their dependencies: they are obsolete and not
    useful anymore.
 -- Ubuntu daily release <email address hidden> Mon, 10 Nov 2014 13:23:06 +0000

Changed in history-service (Ubuntu):
status: In Progress → Fix Released
Bill Filler (bfiller)
Changed in history-service:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.