OpenStack Heat

Listing outputs in unnecessarily slow in Pike

Bug #1719340 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Zane Bitter
OpenStack Heat queens-1
Pike
Fix Committed
High
Zane Bitter
Queens
Fix Released
Medium
Zane Bitter
OpenStack Heat queens-1

Bug Description

The list_outputs API just provides a list of the outputs defined in the template, and not any of the values. In Pike, however, we calculate all of the data needed to show the values (but don't return it) due to a misunderstanding of what list_outputs does. This makes what should be a very fast API potentially as slow a show_stack with resolve_outputs=True.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/507207

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/507207
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=9b5f66351f450a0796d46e54f23106551cc87193
Submitter: Jenkins
Branch: master

commit 9b5f66351f450a0796d46e54f23106551cc87193
Author: Zane Bitter <email address hidden>
Date: Mon Sep 25 11:24:39 2017 -0400

    Don't load resource data for list_outputs

    This RPC call only generates a list of the outputs defined in the template,
    not their values, so don't load the resource data needed to calculate the
    output values (which can be very slow).

    Also, explicitly pass resolve_value=False instead of relying on the default
    argument (which is different for format_stack_output() and
    format_stack_outputs()), to reduce future confusion.

    Change-Id: I79aae94b6552d465db6707cd4a40cd53ff18455b
    Closes-Bug: #1719340

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 10.0.0.0b1

This issue was fixed in the openstack/heat 10.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/535932

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/pike)

Reviewed: https://review.openstack.org/535932
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=2c9032c675dd712db2b4e06264b12d8622160993
Submitter: Zuul
Branch: stable/pike

commit 2c9032c675dd712db2b4e06264b12d8622160993
Author: Zane Bitter <email address hidden>
Date: Mon Sep 25 11:24:39 2017 -0400

    Don't load resource data for list_outputs

    This RPC call only generates a list of the outputs defined in the template,
    not their values, so don't load the resource data needed to calculate the
    output values (which can be very slow).

    Also, explicitly pass resolve_value=False instead of relying on the default
    argument (which is different for format_stack_output() and
    format_stack_outputs()), to reduce future confusion.

    Change-Id: I79aae94b6552d465db6707cd4a40cd53ff18455b
    Closes-Bug: #1719340
    (cherry picked from commit 9b5f66351f450a0796d46e54f23106551cc87193)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 9.0.3

This issue was fixed in the openstack/heat 9.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.