Remove set_time_override in timeutils

I'm not crazy about this approach of making changes throughout the project; updating all of the projects and then removing the wrapper in oslo, then updating the libs in all of the projects again is really something that should not be a top priority.

I do however think that the usage should be allowed to fall off naturally as other efforts are made to update to using mock, once that's done we should eventually just find that this wrapper is no longer needed and remove it from oslo at that time.

I agree with John, this hardly seems worth the patches and churn

John, Joe,

This is one of the graduation conditions which came up at the summit. This is not urgent and will be a long time goal for timeutils.

https://review.openstack.org/#/c/65602/

https://review.openstack.org/#/c/65724/

Fix proposed to branch: master
Review: https://review.openstack.org/65841

https://review.openstack.org/#/c/65832/

Reviewed: https://review.openstack.org/65832
Committed: https://git.openstack.org/cgit/openstack/tuskar/commit/?id=42c676194d9800719a356e4b6452e65b289e64c9
Submitter: Jenkins
Branch: master

commit 42c676194d9800719a356e4b6452e65b289e64c9
Author: Zhongyue Luo <email address hidden>
Date: Fri Jan 10 08:16:56 2014 +0800

    Removes unused TimeOverride class

    The class TimeOverride is currently not used anywhere in the codebase.
    Also set_time_override function is planned to be removed for
    incubation graduation. Using mock or fixtures to mock utcnow is preferred.

    Change-Id: I007bdd8ffe7ed37d02f6f6077dc572ef95a2a072
    Partial-Bug: #1266962

Reviewed: https://review.openstack.org/65724
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=765e43bb51fce98d411010723f82094fadb399a0
Submitter: Jenkins
Branch: master

commit 765e43bb51fce98d411010723f82094fadb399a0
Author: Zhongyue Luo <email address hidden>
Date: Fri Jan 10 01:56:15 2014 +0900

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Partial-Bug: #1266962

    Change-Id: I56935911a08ccd9847419eb118af2d2c9dd6c1cd

Reviewed: https://review.openstack.org/65841
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=d3f3fd775916b9e93aacdc55af54870eea282fee
Submitter: Jenkins
Branch: master

commit d3f3fd775916b9e93aacdc55af54870eea282fee
Author: Zhongyue Luo <email address hidden>
Date: Fri Jan 10 09:07:16 2014 +0800

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: I9a0727edab12ccd5f1e4eb4f5f62d588f5a0faee
    Partial-Bug: #1266962

Fix proposed to branch: master
Review: https://review.openstack.org/67432

Related fix proposed to branch: master
Review: https://review.openstack.org/67484

Reviewed: https://review.openstack.org/65602
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=c71131a50994d95ae869442fc25e7c3511a5ddbc
Submitter: Jenkins
Branch: master

commit c71131a50994d95ae869442fc25e7c3511a5ddbc
Author: Zhongyue Luo <email address hidden>
Date: Thu Jan 9 10:24:34 2014 +0800

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: I809825560b0324498010bd93aa1ceef552554375
    Partial-Bug: #1266962

Fix proposed to branch: master
Review: https://review.openstack.org/67826

Reviewed: https://review.openstack.org/67484
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=70ebb197a112bbc832bf8528b69dcfc164288539
Submitter: Jenkins
Branch: master

commit 70ebb197a112bbc832bf8528b69dcfc164288539
Author: Roman Podoliaka <email address hidden>
Date: Fri Jan 17 16:26:24 2014 +0200

    Fix mocking of utcnow() for model datetime cols

    Now when we are going to deprecate timeutils.set_time_override()
    and use mock instead, it easy to hit the following gotcha: when
    testr does tests discovering, it imports all modules within a given
    directory and it might happen that common.db.sqlalchemy.models
    is imported before timeutils.utcnow() is mocked in a test case.
    In this case the SQLAlchemy model will save the reference to the
    original timeutils.utcnow() function, which will be called later
    when the model will be saved to a DB, if created_at or updated_at
    value aren't provided.

    In order to overcome this we can defer resolution of timeutils.utcnow
    reference by passing lambda functions to SA Column __init__().

    Related-Bug: #1266962

    Change-Id: I7adce90eacb4a3f334d77da7b4a176c31ff818ed

Fix proposed to branch: master
Review: https://review.openstack.org/67857

Reviewed: https://review.openstack.org/68365
Committed: https://git.openstack.org/cgit/openstack/marconi/commit/?id=0d0694d7020cc98daaeb1e88592aa6d603e1a5a6
Submitter: Jenkins
Branch: master

commit 0d0694d7020cc98daaeb1e88592aa6d603e1a5a6
Author: Flavio Percoco <email address hidden>
Date: Wed Jan 22 13:39:00 2014 +0100

    Don't use `override_time` but mock instead

    Closes-bug: #1266962

    We're moving away from using the set_override_time function in
    timeutils. The right way to do it should be by using mock.

    Change-Id: Ic69c5c5d66cb39d668015c368add10b108684549

Reviewed: https://review.openstack.org/67826
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=ef3cc9c63549496c68ed49b6ca236a65e71fde3f
Submitter: Jenkins
Branch: master

commit ef3cc9c63549496c68ed49b6ca236a65e71fde3f
Author: ZhiQiang Fan <email address hidden>
Date: Mon Jan 20 21:05:25 2014 +0800

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: I7c3793d7a442dc85aec405041c3c9ce6f7503bd8
    Closes-Bug: #1266962

There's a use case that is covered by this function that won't work with mock.

SQLAlchemy models can use something like a default value for colum with default=<func>. If <func> is set to datetime.datetime.utcnow, then it will be used to generate a default value. And no mocking can change that since the reference is already copied into the SQLAlchemy object – it's done at import time of our model module.

Here the time overriding mechanism is useful, since we can use default=timeutils.utcnow and use the override value to trick SQLAlchemy when it will call that function.

FTR, in today's Oslo meeting bnemec suggested moving the mock-able time function into the oslo.db library so it can be used for the case Julien points out, and so that it is clear that it should only be used for that case.

I believe this patch should solve the time mocking for sa, no?

https://review.openstack.org/#/c/67484/

Fix proposed to branch: master
Review: https://review.openstack.org/71737

Fix proposed to branch: master
Review: https://review.openstack.org/72061

Fix proposed to branch: master
Review: https://review.openstack.org/72864

Just blocked https://review.openstack.org/#/c/67857/ as it looks like we need an alternative to advance_time_seconds() before removing set_time_override().

Dolph,

advance_time_seconds does not need an alternative since we can just change the mock value for utcnow()

see https://review.openstack.org/#/c/72200/4/tests/unit/test_periodic.py

Fix proposed to branch: master
Review: https://review.openstack.org/73168

Reviewed: https://review.openstack.org/72864
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=ce2ac6901d8d147dbe39f0d360cdeec268257637
Submitter: Jenkins
Branch: master

commit ce2ac6901d8d147dbe39f0d360cdeec268257637
Author: Zhongyue Luo <email address hidden>
Date: Wed Feb 12 15:45:44 2014 +0800

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: Ida9b5b0130a38f45e1f51bf4fbdb1d1a5851cf82
    Partial-Bug: #1266962

Reviewed: https://review.openstack.org/67432
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=db142161598941330e7563d32fae41ef8867dadb
Submitter: Jenkins
Branch: master

commit db142161598941330e7563d32fae41ef8867dadb
Author: Mikhail Durnosvistov <email address hidden>
Date: Fri Jan 17 06:30:09 2014 -0500

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: Ibcf6d4abee4a52bc459fc322e6a5268d39d70450
    Partial-Bug: #1266962

Reviewed: https://review.openstack.org/71737
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e3eb709b08e52e24cd7e3225a73154efc62ba9fa
Submitter: Jenkins
Branch: master

commit e3eb709b08e52e24cd7e3225a73154efc62ba9fa
Author: Zhongyue Luo <email address hidden>
Date: Fri Feb 7 12:43:58 2014 +0800

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: I057d4bc3a8b1d4e96e6830cd3071dc96a05496dc
    Partial-Bug: #1266962

novaclient 2.16.0 released on 2/26/2014

Fix proposed to branch: master
Review: https://review.openstack.org/78833

Related fix proposed to branch: master
Review: https://review.openstack.org/78847

Related fix proposed to branch: master
Review: https://review.openstack.org/78848

Reviewed: https://review.openstack.org/78847
Committed: https://git.openstack.org/cgit/openstack/marconi/commit/?id=0d0f3b34c0cbef90eb19686bb9c00c413f1e17b0
Submitter: Jenkins
Branch: master

commit 0d0f3b34c0cbef90eb19686bb9c00c413f1e17b0
Author: Zhongyue Luo <email address hidden>
Date: Fri Mar 7 11:29:47 2014 +0800

    Remove unused method from timeutils

    Marconi no longer uses set_time_override. Therefore there is no need to
    invoke clear_time_override anymore.

    Change-Id: Ifa5c6ab958130b2edbce57780fe6462ebfc37409
    Related-Bug: #1266962

Reviewed: https://review.openstack.org/67857
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=f356607a955a30c59ce7990e06432795a43c767b
Submitter: Jenkins
Branch: master

commit f356607a955a30c59ce7990e06432795a43c767b
Author: Mikhail Durnosvistov <email address hidden>
Date: Mon Jan 20 10:03:37 2014 -0500

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: I1af631f36c813740dbf22da030c2c1f50265d156
    Partial-Bug: #1266962

Reviewed: https://review.openstack.org/78848
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=ebd9e9bbaf14c8b7096d5671c95faf2baed585ea
Submitter: Jenkins
Branch: master

commit ebd9e9bbaf14c8b7096d5671c95faf2baed585ea
Author: Zhongyue Luo <email address hidden>
Date: Fri Mar 7 11:34:09 2014 +0800

    Remove unused method from timeutils

    Ironic no longer uses set_time_override. Therefore there is no need to
    invoke clear_time_override anymore.

    Change-Id: I502d7bb6bd22b9ad9239cd78c80938d5925347d2
    Related-Bug: #1266962

Reviewed: https://review.openstack.org/73168
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=ed52d4538c5a7601bc5d0d1b6c4769eb9ed65653
Submitter: Jenkins
Branch: master

commit ed52d4538c5a7601bc5d0d1b6c4769eb9ed65653
Author: Zhongyue Luo <email address hidden>
Date: Thu Feb 13 15:44:50 2014 +0900

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: I203f7369943b948e0462becbddcba65b2d1576f0
    Partial-Bug: #1266962

Reviewed: https://review.openstack.org/78833
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=5722c168f8b05d516b31c3717d0315741388eb54
Submitter: Jenkins
Branch: master

commit 5722c168f8b05d516b31c3717d0315741388eb54
Author: Zhongyue Luo <email address hidden>
Date: Fri Mar 7 08:41:58 2014 +0800

    Removes direct access of timeutils.override_time

    The attribute "override_time" is a private attribute which
    should only be set through "timeutils.set_time_override()".
    There are a number of places in Ceilometer which the override_time
    attribute is set directly and such behavior should be prohibited.

    However the "set_time_override()" function along with "override_time"
    in timeutils is planned to be removed, therefore we no longer
    need to use it.

    Change-Id: I6f3a5e0bb4e4c448f369dd5ead0e1525fd2262e6
    Related-Bug: #1266962

Patch in oslo.utils: https://review.openstack.org/137813

It is not entirely clear to me that this was either entirely fixed in Glance or not, so I'm going to look into it. In the meantime zyluo didn't seem to be working on it.

This was entirely fixed by Zhongyue Luo. All references to the attributes and functions to be removed from timeutils exist solely in the timeutils module in Glance.

Change abandoned by Joe Gordon (<email address hidden>) on branch: master
Review: https://review.openstack.org/137383
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Solving an inconsistency: The bug is 'In Progress' but without an assignee. I set the status back to the last known status before the change to 'In Progress'.

Feel free to assign the bug to yourself. If you do so, please set it to 'In Progress'.

Fix proposed to branch: master
Review: https://review.openstack.org/394779

Fix proposed to branch: master
Review: https://review.openstack.org/397621

Reviewed: https://review.openstack.org/394779
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5805a075b55a9f7faec8d17ed6840ca94b5d5c39
Submitter: Jenkins
Branch: master

commit 5805a075b55a9f7faec8d17ed6840ca94b5d5c39
Author: Luong Anh Tuan <email address hidden>
Date: Tue Nov 8 13:24:55 2016 +0700

    Remove timeutils.clear_time_override in neutron

    The clear_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: I7baa623fd71a7d03acc61dd1f18287bb654539cd
    Partial-Bug: #1266962

Reviewed: https://review.openstack.org/397621
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d111600753ce7c1bfa8b1ad1c8e0ddf908555abc
Submitter: Jenkins
Branch: master

commit d111600753ce7c1bfa8b1ad1c8e0ddf908555abc
Author: Dao Cong Tien <email address hidden>
Date: Tue Nov 15 16:42:27 2016 +0700

    Remove use of timeutils.set_time_override

    As timeutils.set_time_override() was created to mock utcnow
    before 'mock' was generally used, now we should remove it.

    Change-Id: I8257a969c14e438a10cf79fa300a18ae3f0128c3
    Partial-Bug: #1266962

Related fix proposed to branch: master
Review: https://review.openstack.org/504346

Related fix proposed to branch: master
Review: https://review.openstack.org/504390

Reviewed: https://review.openstack.org/504320
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=902a66e53d29101a23c541c8b1090a33b8d89fb0
Submitter: Jenkins
Branch: master

commit 902a66e53d29101a23c541c8b1090a33b8d89fb0
Author: zhangyangyang <email address hidden>
Date: Fri Sep 15 11:25:18 2017 +0800

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: Ibbdae2ba60f3d706eba59d8af13cf7ee9acfae23
    Closes-Bug:#1266962

Reviewed: https://review.openstack.org/504776
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=b263fb17b7fb613811bd80053a4d82eb7bb801d8
Submitter: Jenkins
Branch: master

commit b263fb17b7fb613811bd80053a4d82eb7bb801d8
Author: zhangyangyang <email address hidden>
Date: Sun Sep 17 22:15:00 2017 +0800

    Removes use of timeutils.set_time_override

    The set_time_override function in timeutils was written as a
    helper function to mock utcnow for unittests before 'mock' was
    generally used. Now that we have mock and fixture, we no longer
    need to use it.

    Change-Id: I8106c27dd839e71fa0e5140f77b098a8872999b8
    Closes-Bug:#1266962

Change abandoned by zhangyangyang (<email address hidden>) on branch: master
Review: https://review.openstack.org/504346

Change abandoned by zhangyangyang (<email address hidden>) on branch: master
Review: https://review.openstack.org/504390

Change abandoned by zhangyangyang (<email address hidden>) on branch: master
Review: https://review.openstack.org/504323

Change abandoned by zhangyangyang (<email address hidden>) on branch: master
Review: https://review.openstack.org/504773

This issue was fixed in the openstack/manila 6.0.0.0b1 development milestone.

This issue was fixed in the openstack/ceilometer 10.0.0 release.

removed keystonemiddleware as LP will timeout when trying to update.