hacking

pyflakes till 2.1.0 not compatible with py3.8 (ubuntu focal)

Bug #1886296 reported by Ghanshyam Mann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Blazar
Fix Released
Undecided
Ghanshyam Mann
Mistral
Fix Released
Undecided
Unassigned
cloudkitty
Fix Released
Undecided
Ghanshyam Mann
hacking
Fix Released
Undecided
Ghanshyam Mann

Bug Description

pyflakes till 2.1.0 is not comaptible with python 3.8 which is default on ubuntu focal.

While migrating the OpenStack CI/CD to Ubuntu focal where python 3.8 is default python version, pep8 job run on python3.8 and fail

AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'

- https://zuul.opendev.org/t/openstack/build/68788de0821942a6a81807b52355c9ac

We need to bump the pyflakes to 2.1.1 as min version to run pep8 jobs on py3.8

pyflakes issue:
https://github.com/PyCQA/pyflakes/issues/367

Ghanshyam Mann (ghanshyammann)
Changed in hacking:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
Revision history for this message
Ghanshyam Mann (ghanshyammann) wrote :

hacking fix - https://review.opendev.org/#/c/739334/
blazar- https://review.opendev.org/#/c/739315/
cloudkitty -https://review.opendev.org/#/c/739319/

Changed in hacking:
status: New → In Progress
Changed in blazar:
status: New → In Progress
Changed in cloudkitty:
status: New → In Progress
Changed in blazar:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
Changed in cloudkitty:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to blazar-tempest-plugin (master)

Fix proposed to branch: master
Review: https://review.opendev.org/740357

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on blazar-tempest-plugin (master)

Change abandoned by Ghanshyam Mann (<email address hidden>) on branch: master
Review: https://review.opendev.org/739314
Reason: doing in other patch due to wrong commit-id here https://review.opendev.org/#/c/740357/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cloudkitty-tempest-plugin (master)

Fix proposed to branch: master
Review: https://review.opendev.org/740361

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cloudkitty-tempest-plugin (master)

Change abandoned by Ghanshyam Mann (<email address hidden>) on branch: master
Review: https://review.opendev.org/739319
Reason: doing in https://review.opendev.org/#/c/740361/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to blazar-tempest-plugin (master)

Reviewed: https://review.opendev.org/740357
Committed: https://git.openstack.org/cgit/openstack/blazar-tempest-plugin/commit/?id=339c3e1e269c9d3616b38b83b0f0f6d5228e5aef
Submitter: Zuul
Branch: master

commit 339c3e1e269c9d3616b38b83b0f0f6d5228e5aef
Author: Ghanshyam Mann <email address hidden>
Date: Sat Jul 4 12:46:28 2020 -0500

    migrate testing to ubuntu focal

    As per victoria cycle testing runtime and community goal[1]
    we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

    Fixing:
    - bug#1886296
    Bump the pyflakes to 2.1.1 as min version to run pep8 jobs
    on py3.8 which is default python vesion in ubuntu focal.

    Story: #2007865
    Task: #40178

    Closes-Bug: #1886296
    [1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal.html

    Change-Id: I295c8e2fe6b135833b33cdf9d405d169f358c083

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to hacking (master)

Reviewed: https://review.opendev.org/739334
Committed: https://git.openstack.org/cgit/openstack/hacking/commit/?id=93e6cd290471f9e58f6d052eea508213a55f98c3
Submitter: Zuul
Branch: master

commit 93e6cd290471f9e58f6d052eea508213a55f98c3
Author: Ghanshyam Mann <email address hidden>
Date: Sat Jul 4 21:17:01 2020 -0500

    migrate testing to ubuntu focal

    As per victoria cycle testing runtime and community goal[1]
    we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

    Fixing:
    - bug#1886296
    Bump the flake8 to 3.8.0 as min so that pyflakes 2.1.1 as min version taken
    care to run pep8 jobs on py3.8 which is default python vesion in ubuntu focal.
    - https://github.com/PyCQA/flake8/blob/3.8.0/setup.cfg#L44

    Story: #2007865
    Task: #40212

    Closes-Bug: #1886296
    [1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal.html

    Change-Id: I19b13d5d63bce0f6b646972b09cfe8e8d7c22adc

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cloudkitty-dashboard (master)

Reviewed: https://review.opendev.org/739320
Committed: https://git.openstack.org/cgit/openstack/cloudkitty-dashboard/commit/?id=c05db4825ff8d61b3d6c3b493ce1a58d57bb4752
Submitter: Zuul
Branch: master

commit c05db4825ff8d61b3d6c3b493ce1a58d57bb4752
Author: Ghanshyam Mann <email address hidden>
Date: Sat Jul 4 12:55:51 2020 -0500

    [goal] Migrate testing to ubuntu focal

    As per victoria cycle testing runtime and community goal[1]
    we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

    Fixing:
    - bug#1886296
    Bump the pyflakes to 2.1.1 as min version to run pep8 jobs
    on py3.8 which is default python vesion in ubuntu focal.

    Story: #2007865
    Task: #40180

    Closes-Bug: #1886296
    [1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal.html

    Change-Id: I482ac98bc56f0e3cfb8b767f47649da11ed1afab

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cloudkitty-tempest-plugin (master)

Reviewed: https://review.opendev.org/740361
Committed: https://git.openstack.org/cgit/openstack/cloudkitty-tempest-plugin/commit/?id=4ceb427d4f4c7645f368f7ac0c1b1443498344d8
Submitter: Zuul
Branch: master

commit 4ceb427d4f4c7645f368f7ac0c1b1443498344d8
Author: Ghanshyam Mann <email address hidden>
Date: Sat Jul 4 12:55:20 2020 -0500

    migrate testing to ubuntu focal

    As per victoria cycle testing runtime and community goal[1]
    we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

    Fixing:
    - bug#1886296
    Bump the pyflakes to 2.1.1 as min version to run pep8 jobs
    on py3.8 which is default python vesion in ubuntu focal.

    Story: #2007865
    Task: #40180

    Closes-Bug: #1886296
    [1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal.html

    Change-Id: I5628be1786bc098232db44d0b74b1b2d0b828bbd

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cloudkittyclient (master)

Reviewed: https://review.opendev.org/739318
Committed: https://git.openstack.org/cgit/openstack/python-cloudkittyclient/commit/?id=de3c4924e93dcad0b1f748807425e9a0b435e501
Submitter: Zuul
Branch: master

commit de3c4924e93dcad0b1f748807425e9a0b435e501
Author: Ghanshyam Mann <email address hidden>
Date: Sat Jul 4 12:54:50 2020 -0500

    migrate testing to ubuntu focal

    As per victoria cycle testing runtime and community goal[1]
    we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

    Fixing:
    - bug#1886296
    Bump the pyflakes to 2.1.1 as min version to run pep8 jobs
    on py3.8 which is default python vesion in ubuntu focal.

    Story: #2007865
    Task: #40180

    Closes-Bug: #1886296
    [1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal.html

    Change-Id: I482ac98bc56f0e3cfb8b767f47649da11ed1afab

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral-dashboard (master)

Reviewed: https://review.opendev.org/744718
Committed: https://git.openstack.org/cgit/openstack/mistral-dashboard/commit/?id=c9e8d95c0945d7f6354c3b7198823d3cd56b27cf
Submitter: Zuul
Branch: master

commit c9e8d95c0945d7f6354c3b7198823d3cd56b27cf
Author: manchandavishal <email address hidden>
Date: Tue Aug 4 13:58:26 2020 +0000

    [goal] Migrate testing to ubuntu focal

    As per victoria cycle testing runtime and community goal[1]
    we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

    Fixing:
    Closes-Bug: #1886296
    Bump the pyflakes to 2.1.1 as min version to run pep8 jobs
    on py3.8 which is default python vesion in ubuntu focal.

    Story: #2007865
    Task: #40196

    [1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal.html
    Change-Id: I29eae255a0cb87c41d1d739e3bb608c303c5b9b8

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cloudkitty (master)

Change abandoned by Ghanshyam Mann (<email address hidden>) on branch: master
Review: https://review.opendev.org/739317
Reason: most of changed already merged, testing in https://review.opendev.org/#/c/750534/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/blazar-nova 2.2.0

This issue was fixed in the openstack/blazar-nova 2.2.0 release.

Radosław Piliszek (yoctozepto)
Changed in blazar:
status: In Progress → Fix Released
Pierre Riteau (priteau)
Changed in hacking:
status: In Progress → Fix Released
Changed in cloudkitty:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.