Gwibber

Gwibber throws an error if you hit delete button when no accounts are added

Bug #663948 reported by Tom "spot" Callaway on 2010-10-20

This bug affects 18 people

Affects		Status	Importance	Assigned to	Milestone
	Gwibber	Fix Released	Undecided	Unassigned	Gwibber 2.91.0
	gwibber (Ubuntu)	Fix Released	Medium	Unassigned

Bug Description

Originally reported here: https://bugzilla.redhat.com/show_bug.cgi?id=644042

accounts.py:166:on_account_delete:AttributeError: 'GwibberAccountManager'
object has no attribute 'account'

Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/gwibber/accounts.py", line 166, in
on_account_delete
if "id" in self.account:
AttributeError: 'GwibberAccountManager' object has no attribute 'account'

Local variables in innermost frame:
widget: <gtk.Button object at 0x873fd24 (GtkButton at 0x83220f8)>
self: <gwibber.accounts.GwibberAccountManager object at 0x873b4cc>

How to reproduce
-----
1. Open gwibber for the first time
2. Go to menu Edit->Accounts
3. Then press the Remove button in the bottom left.

I've attached a patch to resolve this issue.

Related branches

lp://staging/gwibber

lp://staging/ubuntu/natty/gwibber

lp://staging/~webapps/+junk/gwibber-opensesame-packaging

Revision history for this message

Tom "spot" Callaway (tcallawa) wrote on 2010-10-20:

gwibber-894bzr-do-not-delete-imaginary-accounts.patch Edit (1.6 KiB, text/plain)

Ken VanDine (ken-vandine) on 2010-10-20

Changed in gwibber:
assignee:	nobody → Ken VanDine (ken-vandine)
milestone:	none → 3.0
assignee:	Ken VanDine (ken-vandine) → nobody
status:	New → Fix Committed

Omer Akram (om26er) on 2010-10-27

Changed in gwibber (Ubuntu):
importance:	Undecided → Medium
status:	New → Triaged

Ken VanDine (ken-vandine) on 2010-11-09

Changed in gwibber:
milestone:	3.0 → 2.91.0

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-11-09:

This bug was fixed in the package gwibber - 2.91.0-0ubuntu1

---------------
gwibber (2.91.0-0ubuntu1) natty; urgency=low

  * New unstable release
    - Shouldn't display reply icon for messages from you (LP: #661330)
    - Private messages shouldn't allow public replies (LP: #661358)
    - Private messages shouldn't allow retweets (LP: #661359)
    - Don't clear multi-column streams when activated by the messaging
      indicator (LP: #643487)
    - Save window size/position when it changes, so it doesn't get moved
      unexpectedly when activated by the messaging indicator (LP: #614345)
    - Split gwibber-service backends into plugins so they can be optional
    - gwibber-service will now look for plugins in multiple paths
      * $GWIBBER_PLUGIN_DIR, ~/.local/share/gwibber/plugins,
        /usr/local/share/gwibber/plugins, /usr/share/gwibber/plugins
    - Don't traceback if you attempt to delete an account when there is
      no account selected (LP: #663948)
    - Fixed dupe notifications as well as displaying dupes in the stream
    - Plugins can now return tuples of errors instead of messages, which
      signals the client to display the failure in an Infobar
    - Remove all db access from the client, move all the logic to the service
    - Add appindicator support, to get quicklists if using Unity
    - Use counters in the messaging menu for unseen messages, replies and
      private messages
    - Fix for gwibber-poster man page from Kartik Mistry (LP: #638824)
    - New gwibber-accounts man page from Kartik Mistry (LP: #638824)
    - Clear input entry and account target bar on ESC (LP: #555689)
    - Client will display the infobar with retry, edit account, and clear
      buttons
    - gwibber-accounts: added infobar to display errors passed in from
      the client
    - gwibber-service-statusnet - ported to use oauth1.0a
    - gwibber-service-identica - ported to use oauth1.0a
  * debian/control
    - Dropped recommends for python-desktopcouch-records
    - Split the gwibber-service plugins into separate packages
      * gwibber-service-facebook
      * gwibber-service-twitter
      * gwibber-service-identica
      * gwibber-service-flickr
      * gwibber-service-digg
      * gwibber-service-buzz
      * gwibber-service-statusnet
      * gwibber-service-foursquare
      * gwibber-service-friendfeed
      * gwibber-service-pingfm
      * gwibber-service-qaiku
    - Make the service plugins conflict with gwibber-service <= 2.33.0
  * debian/patches/lp_report_to_ubuntu.patch
    - Updated links to point to natty
-- Ken VanDine <email address hidden> Mon, 18 Oct 2010 17:07:03 -0400

This bug was fixed in the package gwibber - 2.91.0-0ubuntu1

---------------
gwibber (2.91.0-0ubuntu1) natty; urgency=low

* New unstable release
    - Shouldn't display reply icon for messages from you (LP: #661330)
    - Private messages shouldn't allow public replies (LP: #661358)
    - Private messages shouldn't allow retweets (LP: #661359)
    - Don't clear multi-column streams when activated by the messaging
      indicator (LP: #643487)
    - Save window size/position when it changes, so it doesn't get moved
      unexpectedly when activated by the messaging indicator (LP: #614345)
    - Split gwibber-service backends into plugins so they can be optional
    - gwibber-service will now look for plugins in multiple paths
      * $GWIBBER_PLUGIN_DIR, ~/.local/share/gwibber/plugins,
        /usr/local/share/gwibber/plugins, /usr/share/gwibber/plugins
    - Don't traceback if you attempt to delete an account when there is
      no account selected (LP: #663948)
    - Fixed dupe notifications as well as displaying dupes in the stream
    - Plugins can now return tuples of errors instead of messages, which
      signals the client to display the failure in an Infobar
    - Remove all db access from the client, move all the logic to the service
    - Add appindicator support, to get quicklists if using Unity
    - Use counters in the messaging menu for unseen messages, replies and
      private messages
    - Fix for gwibber-poster man page  from Kartik Mistry (LP: #638824)
    - New gwibber-accounts man page from Kartik Mistry (LP: #638824)
    - Clear input entry and account target bar on ESC (LP: #555689)
    - Client will display the infobar with retry, edit account, and clear
      buttons
    - gwibber-accounts: added infobar to display errors passed in from
      the client
    - gwibber-service-statusnet - ported to use oauth1.0a
    - gwibber-service-identica - ported to use oauth1.0a
  * debian/control
    - Dropped recommends for python-desktopcouch-records
    - Split the gwibber-service plugins into separate packages
      * gwibber-service-facebook
      * gwibber-service-twitter
      * gwibber-service-identica
      * gwibber-service-flickr
      * gwibber-service-digg
      * gwibber-service-buzz
      * gwibber-service-statusnet
      * gwibber-service-foursquare
      * gwibber-service-friendfeed
      * gwibber-service-pingfm
      * gwibber-service-qaiku
    - Make the service plugins conflict with gwibber-service <= 2.33.0
  * debian/patches/lp_report_to_ubuntu.patch
    - Updated links to point to natty
 -- Ken VanDine <ken.vandine@canonical.com>   Mon, 18 Oct 2010 17:07:03 -0400