Guadalinex

ubiquity support to override default frontend via kernel option

Bug #364009 reported by Roberto C. Morano
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Guadalinex
In Progress
Wishlist
Juanje Ojeda
Guadalinex beta
ubiquity (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: ubiquity

Hello,

I'm working on Guadalinex a derivated Ubuntu distro, and we have been in the need to override the ubiquity frontend used when the 'only-ubiquity' is used as kernel option.
By default, it uses gtk_ui, but we use a customized one, so I have added support to '/etc/init.d/ubiquity' to parse a 'ubiquity-ui=frontend' option and set it as the frontend used. If no 'ubiquity-ui' option is specified, the default one is used.

I attach a patch for this file. Hope it (at least the idea itself :) can be included in further versions of ubiquity, since I think is a good idea for derivatives :]

Roberto C. Morano (rcmorano)
Changed in guadalinex:
importance: Undecided → Wishlist
milestone: none → beta
Revision history for this message
Roberto C. Morano (rcmorano) wrote :
Revision history for this message
Colin Watson (cjwatson) wrote :

Thanks for your patch.

Your patch is reversed.

Goodness me, that's a lot of work to parse /proc/cmdline. Did you not see the code above in the same init script that iterates over /proc/cmdline in shell, without the need to start awk? You can deal with splitting foo=bar in pure shell too, with something like "${x#*=}".

This isn't your fault, but I'm beginning to become uncomfortable with the number of haphazardly-named boot parameters owned by ubiquity. I'd like to have new parameters namespaced, so perhaps the debconf-style ubiquity/frontend=gtk_ui; I don't mind so much at this point whether that's actually parsed by debconf or by the init script.

Revision history for this message
Roberto C. Morano (rcmorano) wrote :

Sorry, it seems I was a bit high that day hehe

I include a new not-reversed patch using just 1 awk instance and using debconf-style :]

Personally, I don't like the debconf-style options in cmdline because it makes it too large (and it has its limit), but I understand (and I suppose) that these options can/will be included and used directly to/from debconf so it's sounds nice to me.

Thanks for your attention.

Revision history for this message
Roberto C. Morano (rcmorano) wrote :
Juanje Ojeda (juanje)
Changed in guadalinex:
assignee: nobody → Juanje Ojeda (juanje)
status: New → In Progress
Revision history for this message
Juanje Ojeda (juanje) wrote :

This is a new patch for taking the frontend from the /proc/cmdline in the debconf format and parsing the parameters as Colin sugested.

This patch was made against the current verion of the main branch so this apply cleanly.

Changed in ubiquity (Ubuntu):
status: New → In Progress
Colin Watson (cjwatson)
Changed in ubiquity (Ubuntu):
status: In Progress → Fix Committed
importance: Undecided → Wishlist
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 2.5.8

---------------
ubiquity (2.5.8) natty; urgency=low

  * Allow overriding frontend using the ubiquity/frontend= boot parameter
    (thanks, Roberto C. Morano and Juanje Ojeda; LP: #364009).
  * console-setup/codeset was renamed to console-setup/codeset47
    (LP: #699829).
  * Automatic update of included source packages: base-installer
    1.114ubuntu2, console-setup 1.57ubuntu2, netcfg 1.59ubuntu1.
 -- Colin Watson <email address hidden> Fri, 07 Jan 2011 15:09:58 +0000

Changed in ubiquity (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.